diff mbox series

Fix typos (PR other/84819).

Message ID 9f134045-0fe9-bc3b-e4d8-464fdb8ad930@suse.cz
State New
Headers show
Series Fix typos (PR other/84819). | expand

Commit Message

Martin Liška March 20, 2018, 2:18 p.m. UTC 
Hi.

There's patch for couple of documentation issues reported in the PR.

Ready for trunk?
Thanks,
Martin

gcc/ChangeLog:

2018-03-20  Martin Liska  <mliska@suse.cz>

	PR other/84819
	* calls.c (initialize_argument_information): Fix trailing space.
	* common.opt: Fix typo and provide better explanation for
	-fsanitize-coverage option.
	* config/i386/i386.opt: Fix typo.
---
 gcc/calls.c              | 2 +-
 gcc/common.opt           | 4 ++--
 gcc/config/i386/i386.opt | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Gerald Pfeifer March 20, 2018, 3:28 p.m. UTC | #1 
On Tue, 20 Mar 2018, Martin Liška wrote:
> There's patch for couple of documentation issues reported in the PR.

Looks good to me, thanks!

Just, should there be an "a" in "use jump table"?

Gerald
diff --git a/gcc/calls.c b/gcc/calls.c
index 4dcfef77a5a..9eb0467311b 100644
--- a/gcc/calls.c
+++ b/gcc/calls.c
@@ -1999,7 +1999,7 @@ initialize_argument_information (int num_actuals ATTRIBUTE_UNUSED,
 		  *may_tailcall = false;
 		  maybe_complain_about_tail_call (exp,
 						  "a callee-copied argument is"
-						  " stored in the current "
+						  " stored in the current"
 						  " function's frame");
 		}
 
diff --git a/gcc/common.opt b/gcc/common.opt
index e0bc4d1bb18..d6ef85928f3 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -1002,7 +1002,7 @@ Select what to sanitize.
 
 fsanitize-coverage=
 Common Report Joined
-Select what to coverage sanitize.
+Select type of coverage sanitization.
 
 fasan-shadow-offset=
 Common Joined RejectNegative Var(common_deferred_options) Defer
@@ -1637,7 +1637,7 @@ Common Report Joined RejectNegative Enum(cf_protection_level) Var(flag_cf_protec
 instructions have valid targets.
 
 Enum
-Name(cf_protection_level) Type(enum cf_protection_level) UnknownError(unknown Cotrol-Flow Protection Level %qs)
+Name(cf_protection_level) Type(enum cf_protection_level) UnknownError(unknown Control-Flow Protection Level %qs)
 
 EnumValue
 Enum(cf_protection_level) String(full) Value(CF_FULL)
diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i386.opt
index 311b99d9739..9482b7b52db 100644
--- a/gcc/config/i386/i386.opt
+++ b/gcc/config/i386/i386.opt
@@ -1023,7 +1023,7 @@ Enforcement Technology (CET).
 
 mcet-switch
 Target Report Undocumented Var(flag_cet_switch) Init(0)
-Turn on CET instrumentation for switch statements, which use jump table and
+Turn on CET instrumentation for switch statements that use jump table and
 indirect jump.
 
 mforce-indirect-call
Martin Liška March 20, 2018, 3:49 p.m. UTC | #2 
On 03/20/2018 04:28 PM, Gerald Pfeifer wrote:
> On Tue, 20 Mar 2018, Martin Liška wrote:
>> There's patch for couple of documentation issues reported in the PR.
> 
> Looks good to me, thanks!
> 
> Just, should there be an "a" in "use jump table"?

Looks good. And 'an indirect jump.' ?

Martin

> 
> Gerald
>
Martin Liška March 28, 2018, 2:52 p.m. UTC | #3 
On 03/20/2018 04:49 PM, Martin Liška wrote:
> On 03/20/2018 04:28 PM, Gerald Pfeifer wrote:
>> On Tue, 20 Mar 2018, Martin Liška wrote:
>>> There's patch for couple of documentation issues reported in the PR.
>>
>> Looks good to me, thanks!
>>
>> Just, should there be an "a" in "use jump table"?
> 
> Looks good. And 'an indirect jump.' ?
> 
> Martin
> 
>>
>> Gerald
>>

Ok, I installed the patch with both adjustments as r258925.
If there's some additional comment I'll do a follow-up.

Martin
diff mbox series

Patch

diff --git a/gcc/calls.c b/gcc/calls.c
index 4dcfef77a5a..9eb0467311b 100644
--- a/gcc/calls.c
+++ b/gcc/calls.c
@@ -1999,7 +1999,7 @@  initialize_argument_information (int num_actuals ATTRIBUTE_UNUSED,
 		  *may_tailcall = false;
 		  maybe_complain_about_tail_call (exp,
 						  "a callee-copied argument is"
-						  " stored in the current "
+						  " stored in the current"
 						  " function's frame");
 		}
 
diff --git a/gcc/common.opt b/gcc/common.opt
index e0bc4d1bb18..d6ef85928f3 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -1002,7 +1002,7 @@  Select what to sanitize.
 
 fsanitize-coverage=
 Common Report Joined
-Select what to coverage sanitize.
+Select type of coverage sanitization.
 
 fasan-shadow-offset=
 Common Joined RejectNegative Var(common_deferred_options) Defer
@@ -1637,7 +1637,7 @@  Common Report Joined RejectNegative Enum(cf_protection_level) Var(flag_cf_protec
 instructions have valid targets.
 
 Enum
-Name(cf_protection_level) Type(enum cf_protection_level) UnknownError(unknown Cotrol-Flow Protection Level %qs)
+Name(cf_protection_level) Type(enum cf_protection_level) UnknownError(unknown Control-Flow Protection Level %qs)
 
 EnumValue
 Enum(cf_protection_level) String(full) Value(CF_FULL)
diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i386.opt
index 311b99d9739..9482b7b52db 100644
--- a/gcc/config/i386/i386.opt
+++ b/gcc/config/i386/i386.opt
@@ -1023,7 +1023,7 @@  Enforcement Technology (CET).
 
 mcet-switch
 Target Report Undocumented Var(flag_cet_switch) Init(0)
-Turn on CET instrumentation for switch statements, which use jump table and
+Turn on CET instrumentation for switch statements that use jump table and
 indirect jump.
 
 mforce-indirect-call