diff mbox series

Add possibility to turn off promiscuous mode

Message ID 1ad29d4d-ec70-381e-9d57-86f916d6799c@astro-kom.de
State Changes Requested, archived
Delegated to: David Miller
Headers show
Series Add possibility to turn off promiscuous mode | expand

Commit Message

Stephan Mondwurf March 20, 2018, 10:28 a.m. UTC
The driver is capable of switching on the promiscuous mode.

This patch adds the possibility to turn it off again.

Signed-off-by: Stephan Mondwurf <s.mondwurf@astro-kom.de>
---
  drivers/net/ethernet/altera/altera_tse_main.c | 3 +++
  1 file changed, 3 insertions(+)

  		altera_tse_set_mcfilterall(dev);

Comments

David Miller March 20, 2018, 2:36 p.m. UTC | #1
From: Stephan Mondwurf <s.mondwurf@astro-kom.de>
Date: Tue, 20 Mar 2018 11:28:20 +0100

> The driver is capable of switching on the promiscuous mode.
> 
> This patch adds the possibility to turn it off again.
> 
> Signed-off-by: Stephan Mondwurf <s.mondwurf@astro-kom.de>

Please fix your patch submissions.

Your subject line should have an appropriate subsystem prefix, for
drivers like this simply "altera: " is sufficient.  You should
also specify what tree your patch is targetting in the '[PATCH]'
string.  So together that means:

	Subject: [PATCH net] altera: Add possibility to turn off promiscuous mode

or:

	Subject: [PATCH net-next] altera: Add possibility to turn off promiscuous mode

Also, your patches has both been completely corrupted by your email
client.  Long lines have been split up.

Please email the patch to yourself, and try to apply it.  Do not
resubmit the patch to the list here until you can do that
successfully.

Thank you.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/altera/altera_tse_main.c 
b/drivers/net/ethernet/altera/altera_tse_main.c
index 527908c..241d27b 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -1067,6 +1067,9 @@  static void tse_set_rx_mode_hashfilter(struct 
net_device *dev)
  	if (dev->flags & IFF_PROMISC)
  		tse_set_bit(priv->mac_dev, tse_csroffs(command_config),
  			    MAC_CMDCFG_PROMIS_EN);
+	else
+		tse_clear_bit(priv->mac_dev, tse_csroffs(command_config),
+			      MAC_CMDCFG_PROMIS_EN);

  	if (dev->flags & IFF_ALLMULTI)