Patchwork [U-Boot,v3,3/4] ARMV7: OMAP3: boot_flash_env_addr should not be volatile

login
register
mail settings
Submitter Luca Ceresoli
Date March 29, 2011, 4:28 p.m.
Message ID <1301416116-5519-4-git-send-email-luca.ceresoli@comelit.it>
Download mbox | patch
Permalink /patch/88811/
State Superseded
Delegated to: Sandeep Paulraj
Headers show

Comments

Luca Ceresoli - March 29, 2011, 4:28 p.m.
Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Albert Aribaud <albert.aribaud@free.fr>
Cc: Sandeep Paulraj <s-paulraj@ti.com>
---
Changes in v2:
 - this patch is new in v2.

Changes in v3: none.

 arch/arm/cpu/armv7/omap3/mem.c |    2 +-
 include/configs/am3517_evm.h   |    2 +-
 include/configs/omap3_evm.h    |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Wolfgang Denk - April 6, 2011, 7:34 a.m.
Dear Luca Ceresoli,

In message <1301416116-5519-4-git-send-email-luca.ceresoli@comelit.it> you wrote:
> Signed-off-by: Luca Ceresoli <luca.ceresoli@comelit.it>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Albert Aribaud <albert.aribaud@free.fr>
> Cc: Sandeep Paulraj <s-paulraj@ti.com>
> ---
> Changes in v2:
>  - this patch is new in v2.
> 
> Changes in v3: none.
> 
>  arch/arm/cpu/armv7/omap3/mem.c |    2 +-
>  include/configs/am3517_evm.h   |    2 +-
>  include/configs/omap3_evm.h    |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/omap3/mem.c b/arch/arm/cpu/armv7/omap3/mem.c
> index bd914b0..e9de05d 100644
> --- a/arch/arm/cpu/armv7/omap3/mem.c
> +++ b/arch/arm/cpu/armv7/omap3/mem.c
> @@ -39,7 +39,7 @@ unsigned int boot_flash_base;
>  unsigned int boot_flash_off;
>  unsigned int boot_flash_sec;
>  unsigned int boot_flash_type;
> -volatile unsigned int boot_flash_env_addr;
> +unsigned int boot_flash_env_addr;
>  
>  struct gpmc *gpmc_cfg;
>  
> diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
> index 70e8f07..bc2e8bb 100644
> --- a/include/configs/am3517_evm.h
> +++ b/include/configs/am3517_evm.h
> @@ -325,7 +325,7 @@
>  
>  #ifndef __ASSEMBLY__
>  extern unsigned int boot_flash_base;
> -extern volatile unsigned int boot_flash_env_addr;
> +extern unsigned int boot_flash_env_addr;
>  extern unsigned int boot_flash_off;
>  extern unsigned int boot_flash_sec;
>  extern unsigned int boot_flash_type;
> diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> index 5bdb3fd..570e794 100644
> --- a/include/configs/omap3_evm.h
> +++ b/include/configs/omap3_evm.h
> @@ -320,7 +320,7 @@
>  
>  #ifndef __ASSEMBLY__
>  extern unsigned int boot_flash_base;
> -extern volatile unsigned int boot_flash_env_addr;
> +extern unsigned int boot_flash_env_addr;
>  extern unsigned int boot_flash_off;
>  extern unsigned int boot_flash_sec;
>  extern unsigned int boot_flash_type;

Can we please get rid off all these extern declarations in board
config files?  It is a maintenance nightmare that we have to repeat
allt hese stuff in several board config files - this is a clear
indication of a design problem, that needs to be fixed.

Can we please move this stuff to some common place instead?

Thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/arch/arm/cpu/armv7/omap3/mem.c b/arch/arm/cpu/armv7/omap3/mem.c
index bd914b0..e9de05d 100644
--- a/arch/arm/cpu/armv7/omap3/mem.c
+++ b/arch/arm/cpu/armv7/omap3/mem.c
@@ -39,7 +39,7 @@  unsigned int boot_flash_base;
 unsigned int boot_flash_off;
 unsigned int boot_flash_sec;
 unsigned int boot_flash_type;
-volatile unsigned int boot_flash_env_addr;
+unsigned int boot_flash_env_addr;
 
 struct gpmc *gpmc_cfg;
 
diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h
index 70e8f07..bc2e8bb 100644
--- a/include/configs/am3517_evm.h
+++ b/include/configs/am3517_evm.h
@@ -325,7 +325,7 @@ 
 
 #ifndef __ASSEMBLY__
 extern unsigned int boot_flash_base;
-extern volatile unsigned int boot_flash_env_addr;
+extern unsigned int boot_flash_env_addr;
 extern unsigned int boot_flash_off;
 extern unsigned int boot_flash_sec;
 extern unsigned int boot_flash_type;
diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
index 5bdb3fd..570e794 100644
--- a/include/configs/omap3_evm.h
+++ b/include/configs/omap3_evm.h
@@ -320,7 +320,7 @@ 
 
 #ifndef __ASSEMBLY__
 extern unsigned int boot_flash_base;
-extern volatile unsigned int boot_flash_env_addr;
+extern unsigned int boot_flash_env_addr;
 extern unsigned int boot_flash_off;
 extern unsigned int boot_flash_sec;
 extern unsigned int boot_flash_type;