From patchwork Tue Mar 29 16:20:04 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Balaji G X-Patchwork-Id: 88807 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AE82CB6F06 for ; Wed, 30 Mar 2011 03:20:30 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751583Ab1C2QU0 (ORCPT ); Tue, 29 Mar 2011 12:20:26 -0400 Received: from mail-yi0-f46.google.com ([209.85.218.46]:54492 "EHLO mail-yi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750Ab1C2QUZ (ORCPT ); Tue, 29 Mar 2011 12:20:25 -0400 Received: by yia27 with SMTP id 27so144364yia.19 for ; Tue, 29 Mar 2011 09:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :mime-version:content-type:content-transfer-encoding; bh=t+RVM5rbuayWRWuTcbkkcADK6nQnDSV5x9m0bCZIu9I=; b=BBU40BbpTJhpuaKrQQlwTFB69Vp2Gh0Yt0LtUojenRIqhuFk19p2eK2t7EF5IAeTuH b8RpAk8qPdMifKwLhAa+bCwtOKSNRiusLPzGU62VjkvHRo6pruNkRXdyjKNeQnoKRcWC wLhw4tmlpakt72oZQJUVgYIanifItClS34e4g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; b=j49OdCQY6BfzT8RFTSJKUKmdubsbdN4inWggWWclOKF23/JTWMU9PBgp9cHrEGasPP oQ+blf7SJMR8ft+NZs8MZHDDqREFqLdXcNTSa2pm+QE/hYrnCKccKx3cUtpzTSoDz45a Z6PNaSlcTc+sjVcVfw6t1Yr1iARSzaPyntUfo= Received: by 10.151.109.14 with SMTP id l14mr325084ybm.197.1301415624761; Tue, 29 Mar 2011 09:20:24 -0700 (PDT) Received: from localhost.localdomain ([122.174.87.195]) by mx.google.com with ESMTPS id b4sm1922054ybn.23.2011.03.29.09.20.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Mar 2011 09:20:23 -0700 (PDT) From: "G.Balaji" To: shemminger@linux-foundation.org Cc: bridge@lists.linux-foundation.org, netdev@vger.kernel.org, "G.Balaji" Subject: [PATCH] bridge: Fix compilation warning in function br_stp_recalculate_bridge_id() Date: Tue, 29 Mar 2011 21:50:04 +0530 Message-Id: <1301415604-3871-1-git-send-email-balajig81@gmail.com> X-Mailer: git-send-email 1.7.4 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org net/bridge/br_stp_if.c: In function ‘br_stp_recalculate_bridge_id’: net/bridge/br_stp_if.c:216:3: warning: ‘return’ with no value, in function returning non-void Signed-off-by: G.Balaji Acked-by: Stephen Hemminger --- net/bridge/br_stp_if.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c index 5593f5a..9b61d09 100644 --- a/net/bridge/br_stp_if.c +++ b/net/bridge/br_stp_if.c @@ -213,7 +213,7 @@ bool br_stp_recalculate_bridge_id(struct net_bridge *br) /* user has chosen a value so keep it */ if (br->flags & BR_SET_MAC_ADDR) - return; + return false; list_for_each_entry(p, &br->port_list, list) { if (addr == br_mac_zero ||