| Message ID | 1521494181-4653-2-git-send-email-andrew@lunn.ch |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | Fixes to allow mv88e6xxx module to be reloaded | expand |
On Mon, Mar 19, 2018 at 10:16:20PM +0100, Andrew Lunn wrote: > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > we override the trigger mode provided in device tree. And the > interrupt is actually active low, which is what all the current device > tree descriptions use. > > Suggested-by: Uwe Kleine-K�nig <u.kleine-koenig@pengutronix.de> Your locale setting seems broken. Can this please be fixed up during commit? > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > --- > drivers/net/dsa/mv88e6xxx/chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c > index fe46b40195fa..84e6febaf881 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -425,7 +425,7 @@ static int mv88e6xxx_g1_irq_setup(struct mv88e6xxx_chip *chip) > > err = request_threaded_irq(chip->irq, NULL, > mv88e6xxx_g1_irq_thread_fn, > - IRQF_ONESHOT | IRQF_TRIGGER_FALLING, > + IRQF_ONESHOT, > dev_name(chip->dev), chip); You could join the shortend line with the next here. Other than that: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index fe46b40195fa..84e6febaf881 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -425,7 +425,7 @@ static int mv88e6xxx_g1_irq_setup(struct mv88e6xxx_chip *chip) err = request_threaded_irq(chip->irq, NULL, mv88e6xxx_g1_irq_thread_fn, - IRQF_ONESHOT | IRQF_TRIGGER_FALLING, + IRQF_ONESHOT, dev_name(chip->dev), chip); if (err) mv88e6xxx_g1_irq_free_common(chip);
By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING we override the trigger mode provided in device tree. And the interrupt is actually active low, which is what all the current device tree descriptions use. Suggested-by: Uwe Kleine-K�nig <u.kleine-koenig@pengutronix.de> Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)