| Message ID | 20180319175823.22111-1-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hmp: free sev info | expand |
On 03/19/2018 12:58 PM, Marc-André Lureau wrote: > Found thanks to ASAN: > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x7efe20417a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) > #1 0x7efe1f7b2f75 in g_malloc0 ../glib/gmem.c:124 > #2 0x7efe1f7b3249 in g_malloc0_n ../glib/gmem.c:355 > #3 0x558272879162 in sev_get_info /home/elmarco/src/qemu/target/i386/sev.c:414 > #4 0x55827285113b in hmp_info_sev /home/elmarco/src/qemu/target/i386/monitor.c:684 > #5 0x5582724043b8 in handle_hmp_command /home/elmarco/src/qemu/monitor.c:3333 > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > target/i386/monitor.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake <eblake@redhat.com> Worth mentioning in the commit message that this was introduced in commit 63036314. And safe for freeze, as it's fixing a memory usage bug in material new to the 2.12 release.
* Eric Blake (eblake@redhat.com) wrote: > On 03/19/2018 12:58 PM, Marc-André Lureau wrote: > > Found thanks to ASAN: > > > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > > #0 0x7efe20417a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) > > #1 0x7efe1f7b2f75 in g_malloc0 ../glib/gmem.c:124 > > #2 0x7efe1f7b3249 in g_malloc0_n ../glib/gmem.c:355 > > #3 0x558272879162 in sev_get_info /home/elmarco/src/qemu/target/i386/sev.c:414 > > #4 0x55827285113b in hmp_info_sev /home/elmarco/src/qemu/target/i386/monitor.c:684 > > #5 0x5582724043b8 in handle_hmp_command /home/elmarco/src/qemu/monitor.c:3333 > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > --- > > target/i386/monitor.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: Eric Blake <eblake@redhat.com> > > Worth mentioning in the commit message that this was introduced in commit > 63036314. > > And safe for freeze, as it's fixing a memory usage bug in material new to > the 2.12 release. Thanks, I'll pick that up for HMP. Dave > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
* Eric Blake (eblake@redhat.com) wrote: > On 03/19/2018 12:58 PM, Marc-André Lureau wrote: > > Found thanks to ASAN: > > > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > > #0 0x7efe20417a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) > > #1 0x7efe1f7b2f75 in g_malloc0 ../glib/gmem.c:124 > > #2 0x7efe1f7b3249 in g_malloc0_n ../glib/gmem.c:355 > > #3 0x558272879162 in sev_get_info /home/elmarco/src/qemu/target/i386/sev.c:414 > > #4 0x55827285113b in hmp_info_sev /home/elmarco/src/qemu/target/i386/monitor.c:684 > > #5 0x5582724043b8 in handle_hmp_command /home/elmarco/src/qemu/monitor.c:3333 > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > --- > > target/i386/monitor.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: Eric Blake <eblake@redhat.com> > > Worth mentioning in the commit message that this was introduced in commit > 63036314. Queued. I've added: Fixes: 63036314 to the commit message. Dave > And safe for freeze, as it's fixing a memory usage bug in material new to > the 2.12 release. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/target/i386/monitor.c b/target/i386/monitor.c index 011419eba2..a890b3c2ab 100644 --- a/target/i386/monitor.c +++ b/target/i386/monitor.c @@ -696,6 +696,8 @@ void hmp_info_sev(Monitor *mon, const QDict *qdict) } else { monitor_printf(mon, "SEV is not enabled\n"); } + + qapi_free_SevInfo(info); } SevLaunchMeasureInfo *qmp_query_sev_launch_measure(Error **errp)
Found thanks to ASAN: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7efe20417a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38) #1 0x7efe1f7b2f75 in g_malloc0 ../glib/gmem.c:124 #2 0x7efe1f7b3249 in g_malloc0_n ../glib/gmem.c:355 #3 0x558272879162 in sev_get_info /home/elmarco/src/qemu/target/i386/sev.c:414 #4 0x55827285113b in hmp_info_sev /home/elmarco/src/qemu/target/i386/monitor.c:684 #5 0x5582724043b8 in handle_hmp_command /home/elmarco/src/qemu/monitor.c:3333 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- target/i386/monitor.c | 2 ++ 1 file changed, 2 insertions(+)