| Message ID | 20180319153400.25694-1-hdegoede@redhat.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/3] libata: Apply NOLPM quirk to Crucial M500 480 and 960GB SSDs | expand |
On Mon, Mar 19, 2018 at 04:33:58PM +0100, Hans de Goede wrote: > There have been reports of the Crucial M500 480GB model not working > with LPM set to min_power / med_power_with_dipm level. > > It has not been tested with medium_power, but that typically has no > measurable power-savings. > > Note the reporters Crucial_CT480M500SSD3 has a firmware version of MU03 > and there is a MU05 update available, but that update does not mention any > LPM fixes in its changelog, so the quirk matches all firmware versions. > > In my experience the LPM problems with (older) Crucial SSDs seem to be > limited to higher capacity versions of the SSDs (different firmware?), > so this commit adds a NOLPM quirk for the 480 and 960GB versions of the > M500, to avoid LPM causing issues with these SSDs. > > Cc: stable@vger.kernel.org > Reported-and-tested-by: Martin Steigerwald <martin@lichtvoll.de> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Applied 1-3 to libata/for-4.16-fixes. Thanks.
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index aec609f80c4e..53400ce09818 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4538,6 +4538,14 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { ATA_HORKAGE_ZERO_AFTER_TRIM | ATA_HORKAGE_NOLPM, }, + /* 480GB+ M500 SSDs have both queued TRIM and LPM issues */ + { "Crucial_CT480M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | + ATA_HORKAGE_ZERO_AFTER_TRIM | + ATA_HORKAGE_NOLPM, }, + { "Crucial_CT960M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | + ATA_HORKAGE_ZERO_AFTER_TRIM | + ATA_HORKAGE_NOLPM, }, + /* devices that don't properly handle queued TRIM commands */ { "Micron_M500_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, },
There have been reports of the Crucial M500 480GB model not working with LPM set to min_power / med_power_with_dipm level. It has not been tested with medium_power, but that typically has no measurable power-savings. Note the reporters Crucial_CT480M500SSD3 has a firmware version of MU03 and there is a MU05 update available, but that update does not mention any LPM fixes in its changelog, so the quirk matches all firmware versions. In my experience the LPM problems with (older) Crucial SSDs seem to be limited to higher capacity versions of the SSDs (different firmware?), so this commit adds a NOLPM quirk for the 480 and 960GB versions of the M500, to avoid LPM causing issues with these SSDs. Cc: stable@vger.kernel.org Reported-and-tested-by: Martin Steigerwald <martin@lichtvoll.de> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/ata/libata-core.c | 8 ++++++++ 1 file changed, 8 insertions(+)