Patchwork [04/19] s390x: fix s390-virtio-serial

login
register
mail settings
Submitter Alexander Graf
Date March 29, 2011, 1:29 p.m.
Message ID <1301405386-25738-5-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/88776/
State New
Headers show

Comments

Alexander Graf - March 29, 2011, 1:29 p.m.
Commit 6b331efb733a0f913ddc0b7762a1307dec304061 broke the s390 proxy version
of virtio-serial by only taking its PCI brother into account.

So let's adjust s390-virtio-serial the same way as its PCI counterpart, making
it compile and work again.

Signed-off-by: Alexander Graf <agraf@suse.de>
CC: Amit Shah <amit.shah@redhat.com>
---
 hw/s390-virtio-bus.c |    6 +++---
 hw/s390-virtio-bus.h |    4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)
Amit Shah - March 29, 2011, 2:17 p.m.
On (Tue) 29 Mar 2011 [15:29:31], Alexander Graf wrote:
> Commit 6b331efb733a0f913ddc0b7762a1307dec304061 broke the s390 proxy version
> of virtio-serial by only taking its PCI brother into account.
> 
> So let's adjust s390-virtio-serial the same way as its PCI counterpart, making
> it compile and work again.

Ouch, sorry for that!

		Amit

Patch

diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c
index d44eff2..58af164 100644
--- a/hw/s390-virtio-bus.c
+++ b/hw/s390-virtio-bus.c
@@ -139,7 +139,7 @@  static int s390_virtio_serial_init(VirtIOS390Device *dev)
 
     bus = DO_UPCAST(VirtIOS390Bus, bus, dev->qdev.parent_bus);
 
-    vdev = virtio_serial_init((DeviceState *)dev, dev->max_virtserial_ports);
+    vdev = virtio_serial_init((DeviceState *)dev, &dev->serial);
     if (!vdev) {
         return -1;
     }
@@ -355,8 +355,8 @@  static VirtIOS390DeviceInfo s390_virtio_serial = {
     .qdev.alias = "virtio-serial",
     .qdev.size = sizeof(VirtIOS390Device),
     .qdev.props = (Property[]) {
-        DEFINE_PROP_UINT32("max_ports", VirtIOS390Device, max_virtserial_ports,
-                           31),
+        DEFINE_PROP_UINT32("max_ports", VirtIOS390Device,
+                           serial.max_virtserial_ports, 31),
         DEFINE_PROP_END_OF_LIST(),
     },
 };
diff --git a/hw/s390-virtio-bus.h b/hw/s390-virtio-bus.h
index 33379a3..edf6d04 100644
--- a/hw/s390-virtio-bus.h
+++ b/hw/s390-virtio-bus.h
@@ -18,6 +18,7 @@ 
  */
 
 #include "virtio-net.h"
+#include "virtio-serial.h"
 
 #define VIRTIO_DEV_OFFS_TYPE		0	/* 8 bits */
 #define VIRTIO_DEV_OFFS_NUM_VQ		1	/* 8 bits */
@@ -43,8 +44,7 @@  typedef struct VirtIOS390Device {
     BlockConf block;
     NICConf nic;
     uint32_t host_features;
-    /* Max. number of ports we can have for a the virtio-serial device */
-    uint32_t max_virtserial_ports;
+    virtio_serial_conf serial;
     virtio_net_conf net;
 } VirtIOS390Device;