| Message ID | 1521441651-19753-1-git-send-email-igor.pylypiv@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: gemini: fix memory leak | expand |
On Mon, Mar 19, 2018 at 7:40 AM, Igor Pylypiv <igor.pylypiv@gmail.com> wrote: > cppcheck report: > [drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab > > Signed-off-by: Igor Pylypiv <igor.pylypiv@gmail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
From: Igor Pylypiv <igor.pylypiv@gmail.com> Date: Sun, 18 Mar 2018 23:40:51 -0700 > cppcheck report: > [drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab > > Signed-off-by: Igor Pylypiv <igor.pylypiv@gmail.com> Applied, thanks.
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 5eb999a..bd3f6e4 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -540,6 +540,7 @@ static int gmac_setup_txqs(struct net_device *netdev) if (port->txq_dma_base & ~DMA_Q_BASE_MASK) { dev_warn(geth->dev, "TX queue base it not aligned\n"); + kfree(skb_tab); return -ENOMEM; }
cppcheck report: [drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab Signed-off-by: Igor Pylypiv <igor.pylypiv@gmail.com> --- drivers/net/ethernet/cortina/gemini.c | 1 + 1 file changed, 1 insertion(+)