| Message ID | 20180318121737.18731-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | e56a713eac9ae18305e2c6d99cbd5887f256d91a |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | [U-Boot,1/1] usb: rockchip: remove duplicate assignement. | expand |
> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Applied to u-boot-rockchip, thanks!
On 03/19/2018 12:48 AM, Philipp Tomsich wrote: >> Assigning f_rkusb->reboot_flag twice doesn't make sense. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >> --- >> drivers/usb/gadget/f_rockusb.c | 1 - >> 1 file changed, 1 deletion(-) >> > > Applied to u-boot-rockchip, thanks! This should go through Lukasz / usb gadget.
diff --git a/drivers/usb/gadget/f_rockusb.c b/drivers/usb/gadget/f_rockusb.c index d5a10f1904..ad3ae91e6d 100644 --- a/drivers/usb/gadget/f_rockusb.c +++ b/drivers/usb/gadget/f_rockusb.c @@ -552,7 +552,6 @@ static void cb_reboot(struct usb_ep *ep, struct usb_request *req) sizeof(struct fsg_bulk_cb_wrap)); struct f_rockusb *f_rkusb = get_rkusb(); - f_rkusb->reboot_flag = 0; memcpy((char *)cbw, req->buf, USB_BULK_CB_WRAP_LEN); f_rkusb->reboot_flag = cbw->CDB[1]; rockusb_func->in_req->complete = compl_do_reset;
Assigning f_rkusb->reboot_flag twice doesn't make sense. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/usb/gadget/f_rockusb.c | 1 - 1 file changed, 1 deletion(-)