diff mbox series

[U-Boot,1/1] drivers:power:max77693: remove redundant logical constraint

Message ID 20180318105245.10158-1-xypron.glpk@gmx.de
State Accepted
Commit 4bf225aa87a11f5d22b22d469e77d005ad441fd8
Delegated to: Jaehoon Chung
Headers show
Series [U-Boot,1/1] drivers:power:max77693: remove redundant logical constraint | expand

Commit Message

Heinrich Schuchardt March 18, 2018, 10:52 a.m. UTC
As ret is not set when calling max77693_get_vcell() there is no
need to check ret again.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/power/mfd/fg_max77693.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Jaehoon Chung April 26, 2018, 10:30 a.m. UTC | #1
On 03/18/2018 07:52 PM, Heinrich Schuchardt wrote:
> As ret is not set when calling max77693_get_vcell() there is no
> need to check ret again.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Sorry for late. Applied to u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

> ---
>  drivers/power/mfd/fg_max77693.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/power/mfd/fg_max77693.c b/drivers/power/mfd/fg_max77693.c
> index df1550816e..a1407318ef 100644
> --- a/drivers/power/mfd/fg_max77693.c
> +++ b/drivers/power/mfd/fg_max77693.c
> @@ -60,8 +60,6 @@ static int power_update_battery(struct pmic *p, struct pmic *bat)
>  		return ret;
>  
>  	max77693_get_vcell(&pb->bat->voltage_uV);
> -	if (ret)
> -		return ret;
>  
>  	return 0;
>  }
>
diff mbox series

Patch

diff --git a/drivers/power/mfd/fg_max77693.c b/drivers/power/mfd/fg_max77693.c
index df1550816e..a1407318ef 100644
--- a/drivers/power/mfd/fg_max77693.c
+++ b/drivers/power/mfd/fg_max77693.c
@@ -60,8 +60,6 @@  static int power_update_battery(struct pmic *p, struct pmic *bat)
 		return ret;
 
 	max77693_get_vcell(&pb->bat->voltage_uV);
-	if (ret)
-		return ret;
 
 	return 0;
 }