diff mbox series

[U-Boot,1/1] drivers: net: cpsw: remove superfluous assignment.

Message ID 20180318102438.9698-1-xypron.glpk@gmx.de
State Accepted
Commit 4b23d3c86465f366ef6d76866f6464f19dd15135
Delegated to: Joe Hershberger
Headers show
Series [U-Boot,1/1] drivers: net: cpsw: remove superfluous assignment. | expand

Commit Message

Heinrich Schuchardt March 18, 2018, 10:24 a.m. UTC 
In

	int ret = A;
	ret = B;

the first assignment has not effect.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/net/cpsw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joe Hershberger March 19, 2018, 8:23 p.m. UTC | #1 
On Sun, Mar 18, 2018 at 5:24 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> In
>
>         int ret = A;
>         ret = B;
>
> the first assignment has not effect.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger March 26, 2018, 7:26 p.m. UTC | #2 
Hi Heinrich,

https://patchwork.ozlabs.org/patch/887356/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe
diff mbox series

Patch

diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
index b72258f83b..e2395dbeb9 100644
--- a/drivers/net/cpsw.c
+++ b/drivers/net/cpsw.c
@@ -949,7 +949,7 @@  static int _cpsw_recv(struct cpsw_priv *priv, uchar **pkt)
 {
 	void *buffer;
 	int len;
-	int ret = -EAGAIN;
+	int ret;
 
 	ret = cpdma_process(priv, &priv->rx_chan, &buffer, &len);
 	if (ret < 0)