diff mbox series

[nft] tests/shell: Use custom nft binary for ruleset listing

Message ID 20180315225838.26387-1-phil@nwl.cc
State Accepted
Delegated to: Pablo Neira
Headers show
Series [nft] tests/shell: Use custom nft binary for ruleset listing | expand

Commit Message

Phil Sutter March 15, 2018, 10:58 p.m. UTC
Don't assume the system's nft binary is able to correctly list rulesets
generated in tests.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 tests/shell/run-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso March 16, 2018, 8:59 a.m. UTC | #1
On Thu, Mar 15, 2018 at 11:58:38PM +0100, Phil Sutter wrote:
> Don't assume the system's nft binary is able to correctly list rulesets
> generated in tests.

Applied, thanks Phil.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh
index d2f3e96b33b24..431d55590a7df 100755
--- a/tests/shell/run-tests.sh
+++ b/tests/shell/run-tests.sh
@@ -110,7 +110,7 @@  do
 		dumppath="$(dirname ${testfile})/dumps"
 		dumpfile="${dumppath}/$(basename ${testfile}).nft"
 		if [ "$rc_got" == "${POSITIVE_RET}" ] && [ -f ${dumpfile} ]; then
-			test_output=$(${DIFF} ${dumpfile} <(nft list ruleset) 2>&1)
+			test_output=$(${DIFF} ${dumpfile} <($NFT list ruleset) 2>&1)
 			rc_spec=$?
 		fi