| Message ID | 1521143154-19605-1-git-send-email-nerv@dawncrow.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | wine: Depend on shared libraries | expand |
Hi André, On Thu, Mar 15, 2018 at 08:45:54PM +0100, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv@dawncrow.de> > --- > package/wine/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/wine/Config.in b/package/wine/Config.in > index 627a9a7..52d7d2e 100644 > --- a/package/wine/Config.in > +++ b/package/wine/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_WINE > bool "wine" > + depends on !BR2_STATIC_LIBS A dependency comment would be nice. baruch > # Wine only builds on certain architectures > depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" || \ > BR2_HOSTARCH = "powerpc" || BR2_HOSTARCH = "arm" || \
Hello, On Thu, 15 Mar 2018 20:45:54 +0100, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv@dawncrow.de> > --- > package/wine/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/wine/Config.in b/package/wine/Config.in > index 627a9a7..52d7d2e 100644 > --- a/package/wine/Config.in > +++ b/package/wine/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_WINE > bool "wine" > + depends on !BR2_STATIC_LIBS It would be good to explain in the commit log why you're adding this, and perhaps add a comment on top of this line to explain why we have this dependency. Thanks! Thomas
Hello André, On Thu, 15 Mar 2018 22:16:29 +0100, Thomas Petazzoni wrote: > On Thu, 15 Mar 2018 20:45:54 +0100, André Hentschel wrote: > > Signed-off-by: André Hentschel <nerv@dawncrow.de> > > --- > > package/wine/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/wine/Config.in b/package/wine/Config.in > > index 627a9a7..52d7d2e 100644 > > --- a/package/wine/Config.in > > +++ b/package/wine/Config.in > > @@ -1,5 +1,6 @@ > > config BR2_PACKAGE_WINE > > bool "wine" > > + depends on !BR2_STATIC_LIBS > > It would be good to explain in the commit log why you're adding this, > and perhaps add a comment on top of this line to explain why we have > this dependency. Ping ? :-) Thanks, Thomas
Hello,
On Thu, 15 Mar 2018 20:45:54 +0100, André Hentschel wrote:
> Signed-off-by: André Hentschel <nerv@dawncrow.de>
I did a test build, and indeed discovered that wine tries to
unconditionally build a shared library.
I've added a Config.in comment, which required adding a
BR2_PACKAGE_WINE_ARCH_SUPPORTS hidden boolean, and extended the commit
log significantly to explain why we do this change.
And then I've applied.
Thanks,
Thomas
Am 31.03.2018 um 22:43 schrieb Thomas Petazzoni: > Hello, > > On Thu, 15 Mar 2018 20:45:54 +0100, André Hentschel wrote: >> Signed-off-by: André Hentschel <nerv@dawncrow.de> > > I did a test build, and indeed discovered that wine tries to > unconditionally build a shared library. > > I've added a Config.in comment, which required adding a > BR2_PACKAGE_WINE_ARCH_SUPPORTS hidden boolean, and extended the commit > log significantly to explain why we do this change. > > And then I've applied. > > Thanks, > > Thomas > Thanks for that! Had no time for it yet
diff --git a/package/wine/Config.in b/package/wine/Config.in index 627a9a7..52d7d2e 100644 --- a/package/wine/Config.in +++ b/package/wine/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_WINE bool "wine" + depends on !BR2_STATIC_LIBS # Wine only builds on certain architectures depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" || \ BR2_HOSTARCH = "powerpc" || BR2_HOSTARCH = "arm" || \
Signed-off-by: André Hentschel <nerv@dawncrow.de> --- package/wine/Config.in | 1 + 1 file changed, 1 insertion(+)