diff mbox series

[committed] Fix testcase for PR c/84852

Message ID 1521129823-18498-1-git-send-email-dmalcolm@redhat.com
State New
Headers show
Series [committed] Fix testcase for PR c/84852 | expand

Commit Message

David Malcolm March 15, 2018, 4:03 p.m. UTC 
On Thu, 2018-03-15 at 09:32 +0800, Paul Hua wrote:
> Hi:
> 
> The fixits-pr84852-1.c fails on mips64el target.
> 
> FAIL: gcc.dg/fixits-pr84852-1.c (test for excess errors)
> FAIL: gcc.dg/fixits-pr84852-1.c dg-regexp 25 not found:
> ".*fixits-pr84852.c:-812156810:25:"
> 
> see this patch:
> 
> diff --git a/gcc/testsuite/gcc.dg/fixits-pr84852-1.c
> b/gcc/testsuite/gcc.dg/fixits-pr84852-1.c
> index ed88434..98087ab 100644
> --- a/gcc/testsuite/gcc.dg/fixits-pr84852-1.c
> +++ b/gcc/testsuite/gcc.dg/fixits-pr84852-1.c
> @@ -22,4 +22,4 @@ int foo (void) { return strlen(""); }
>  #endif
> 
>  /* We need this, to consume a stray line marker for the bogus
> line.  */
> -/* { dg-regexp ".*fixits-pr84852.c:-812156810:25:" } */
> +/* { dg-regexp ".*fixits-pr84852-1.c:-812156810:25:" } */

Thanks for catching this.

Sorry about the breakage; it affects every target.

I had renamed the testcase, and I missed the failure when reviewing
the test results.

> On Wed, Mar 14, 2018 at 10:10 PM, David Malcolm <dmalcolm@redhat.com>
> wrote:
[...]
> > Successfully bootstrapped and regression-tested on x86_64-pc-linux-
> > gnu;
> > adds 14 PASS results to gcc.sum.
[...]
Reviewing the logs, it turned out to actually be +12 PASS and +2 FAIL.
I'm looking at improving my comparison tool [1] to highlight this better
(in my defense, was dealing with a snow day; sorry about the glitch).

I've committed the fix to trunk as r258559 (and r258561 to credit you).

Dave

[1] https://github.com/davidmalcolm/jamais-vu

gcc/testsuite/ChangeLog:
	PR c/84852
	* gcc.dg/fixits-pr84852-1.c: Fix filename in dg-regexp.
---
 gcc/testsuite/gcc.dg/fixits-pr84852-1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/fixits-pr84852-1.c b/gcc/testsuite/gcc.dg/fixits-pr84852-1.c
index ed88434..98087ab 100644
--- a/gcc/testsuite/gcc.dg/fixits-pr84852-1.c
+++ b/gcc/testsuite/gcc.dg/fixits-pr84852-1.c
@@ -22,4 +22,4 @@  int foo (void) { return strlen(""); }
 #endif
 
 /* We need this, to consume a stray line marker for the bogus line.  */
-/* { dg-regexp ".*fixits-pr84852.c:-812156810:25:" } */
+/* { dg-regexp ".*fixits-pr84852-1.c:-812156810:25:" } */