Patchwork ext4: Use EXT4FS_DEBUG instead of EXT4_DEBUG in fsync.c

login
register
mail settings
Submitter Tao Ma
Date March 28, 2011, 3:41 p.m.
Message ID <1301326873-9551-1-git-send-email-tm@tao.ma>
Download mbox | patch
Permalink /patch/88621/
State Accepted
Headers show

Comments

Tao Ma - March 28, 2011, 3:41 p.m.
From: Tao Ma <boyu.mt@taobao.com>

We have EXT4FS_DEBUG for some old debug and CONFIG_EXT4_DEBUG
for the new mballoc debug, but there isn't any EXT4_DEBUG.

As CONFIG_EXT4_DEBUG seems to be only used in mballoc, use
EXT4FS_DEBUG in fsync.c.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 fs/ext4/fsync.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Theodore Ts'o - May 9, 2011, 1:55 a.m.
On Mon, Mar 28, 2011 at 11:41:12PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> We have EXT4FS_DEBUG for some old debug and CONFIG_EXT4_DEBUG
> for the new mballoc debug, but there isn't any EXT4_DEBUG.
> 
> As CONFIG_EXT4_DEBUG seems to be only used in mballoc, use
> EXT4FS_DEBUG in fsync.c.
> 
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>

It doesn't really matter; although I'm including this patch in the
ext4 tree for consistency's sake.  The whole point of the #ifdef's is
to disable the debugging code.  In general you don't want to enable
all of the code protected by EXT4FS_DEBUG at the same time.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 7f74019..3278d6d 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -36,7 +36,7 @@ 
 
 static void dump_completed_IO(struct inode * inode)
 {
-#ifdef	EXT4_DEBUG
+#ifdef	EXT4FS_DEBUG
 	struct list_head *cur, *before, *after;
 	ext4_io_end_t *io, *io0, *io1;
 	unsigned long flags;