diff mbox series

[U-Boot,v4,1/7] spi: spi_flash: do not fail silently on bad user input

Message ID 20180314231516.1647-2-liambeguin@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show
Series add inital SF tests | expand

Commit Message

Liam Beguin March 14, 2018, 11:15 p.m. UTC 
Make sure the user is notified instead of silently returning an error.

Signed-off-by: Liam Beguin <liambeguin@gmail.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
---
 drivers/mtd/spi/spi_flash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini March 22, 2018, 8:34 p.m. UTC | #1 
On Wed, Mar 14, 2018 at 07:15:10PM -0400, Liam Beguin wrote:

> Make sure the user is notified instead of silently returning an error.
> 
> Signed-off-by: Liam Beguin <liambeguin@gmail.com>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
index 294d9f9d79c6..2e61685d3ea4 100644
--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -320,7 +320,7 @@  int spi_flash_cmd_erase_ops(struct spi_flash *flash, u32 offset, size_t len)
 
 	erase_size = flash->erase_size;
 	if (offset % erase_size || len % erase_size) {
-		debug("SF: Erase offset/length not multiple of erase size\n");
+		printf("SF: Erase offset/length not multiple of erase size\n");
 		return -1;
 	}