From patchwork Mon Mar 28 14:05:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tao Ma X-Patchwork-Id: 88607 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E07BFB6EED for ; Tue, 29 Mar 2011 01:06:11 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754424Ab1C1OGK (ORCPT ); Mon, 28 Mar 2011 10:06:10 -0400 Received: from oproxy1-pub.bluehost.com ([66.147.249.253]:36213 "HELO oproxy1-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754329Ab1C1OGJ (ORCPT ); Mon, 28 Mar 2011 10:06:09 -0400 Received: (qmail 597 invoked by uid 0); 28 Mar 2011 14:06:08 -0000 Received: from unknown (HELO box585.bluehost.com) (66.147.242.185) by oproxy1.bluehost.com.bluehost.com with SMTP; 28 Mar 2011 14:06:08 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=tao.ma; h=Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer:X-Identified-User; b=y2Cx3CVt/2XuRICUASQ/5rk1ri5cSKhBfO/IVavw08DD9SS52aYAoYHBmpukpc8QfDKDChpYH9uX09nqTT9vrakoSol1zvMlY6wPGwn937G4Th71d3kUyP0txyyNWs2X; Received: from [221.217.31.156] (helo=taoma-laptop2) by box585.bluehost.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1Q4D55-0003hl-3L; Mon, 28 Mar 2011 08:06:08 -0600 From: Tao Ma To: linux-ext4@vger.kernel.org Cc: Lukas Czerner Subject: [PATCH v2] ext4: Remove redundant check for first_not_zeroed in ext4_register_li_request. Date: Mon, 28 Mar 2011 22:05:53 +0800 Message-Id: <1301321153-3171-1-git-send-email-tm@tao.ma> X-Mailer: git-send-email 1.7.1 X-Identified-User: {1390:box585.bluehost.com:colyli:tao.ma} {sentby:smtp auth 221.217.31.156 authed with tm@tao.ma} Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Tao Ma We have checked first_not_zeroed == ngroups already above, so remove this redundant check. sbi->s_li_request = NULL above is also removed since it is NULL already. Cc: Lukas Czerner Signed-off-by: Tao Ma --- fs/ext4/super.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 2d1378f..c5a48dc 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2948,15 +2948,8 @@ static int ext4_register_li_request(struct super_block *sb, if (first_not_zeroed == ngroups || (sb->s_flags & MS_RDONLY) || - !test_opt(sb, INIT_INODE_TABLE)) { - sbi->s_li_request = NULL; + !test_opt(sb, INIT_INODE_TABLE)) return 0; - } - - if (first_not_zeroed == ngroups) { - sbi->s_li_request = NULL; - return 0; - } elr = ext4_li_request_new(sb, first_not_zeroed); if (!elr)