From patchwork Mon Mar 28 11:59:55 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Plyatov X-Patchwork-Id: 88595 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B9AADB6F92 for ; Mon, 28 Mar 2011 23:00:09 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539Ab1C1MAH (ORCPT ); Mon, 28 Mar 2011 08:00:07 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:64275 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752523Ab1C1MAG (ORCPT ); Mon, 28 Mar 2011 08:00:06 -0400 Received: by fxm17 with SMTP id 17so2566754fxm.19 for ; Mon, 28 Mar 2011 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=ff/LqQGEoF6+b8zfb901EB4PqR7hKw5fw02KUWqA5CE=; b=H89DGqEEW7uZN26RTxNWshmL3vDuVJhEzOv7DL2u23kZCvMIYyCw5pj2zZHyBK81E7 XBnxBtUK5pwdyrHylL/tn6kPLhfrWMytPURFzwY/0S5mHkpQQVwZo8C/OnCnct4kguM6 9Q17OFgKFOEdrJ1tMIv8Y1aZ6cv3FPdIgk4gg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=IvirFu4amv3jUbbFqtnaQLdT8OnZWULAJv+CUFOuRgp0GwuBaSCUW9MV17M+RNBWoU um0IjpQUscHn2iekGvPmocQEcQ2+Od1BOBSD9URzzndHh7gid8t5szHloi4NmpueOFpo 1hijTAflc6PdICSo8lWutftnLEewgUOt46Ojs= Received: by 10.223.159.9 with SMTP id h9mr3330628fax.145.1301313604742; Mon, 28 Mar 2011 05:00:04 -0700 (PDT) Received: from localhost.localdomain ([109.165.12.222]) by mx.google.com with ESMTPS id b18sm1448713fak.8.2011.03.28.05.00.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Mar 2011 05:00:03 -0700 (PDT) From: Igor Plyatov To: Jeff Garzik , linux-ide@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Igor Plyatov Subject: [PATCH v3] ata: pata_at91.c bugfix for high master clock Date: Mon, 28 Mar 2011 15:59:55 +0400 Message-Id: <1301313595-23156-1-git-send-email-plyatov@gmail.com> X-Mailer: git-send-email 1.7.1 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org The AT91SAM9 microcontrollers with master clock higher then 105 MHz and PIO0, have overflow of the NCS_RD_PULSE value in the MSB. This lead to "NCS_RD_PULSE" pulse longer then "NRD_CYCLE" pulse and driver does not detect ATA device. Signed-off-by: Igor Plyatov --- drivers/ata/pata_at91.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c index d1aaeb5..3c2bf86 100644 --- a/drivers/ata/pata_at91.c +++ b/drivers/ata/pata_at91.c @@ -33,11 +33,12 @@ #define DRV_NAME "pata_at91" -#define DRV_VERSION "0.1" +#define DRV_VERSION "0.2" #define CF_IDE_OFFSET 0x00c00000 #define CF_ALT_IDE_OFFSET 0x00e00000 #define CF_IDE_RES_SIZE 0x08 +#define NCS_RD_PULSE_LIMIT 0x3f /* maximal value for pulse bitfields */ struct at91_ide_info { unsigned long mode; @@ -110,6 +111,11 @@ static void set_smc_timing(struct device *dev, /* (CS0, CS1, DIR, OE) <= (CFCE1, CFCE2, CFRNW, NCSX) timings */ ncs_read_setup = 1; ncs_read_pulse = read_cycle - 2; + if (ncs_read_pulse > NCS_RD_PULSE_LIMIT) { + ncs_read_pulse = NCS_RD_PULSE_LIMIT; + dev_warn(dev, "ncs_read_pulse limited to maximal value %lu\n", + ncs_read_pulse); + } /* Write timings same as read timings */ write_cycle = read_cycle;