diff mbox

More toplevel configure.ac pruning

Message ID Pine.LNX.4.64.1103281132470.18010@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers March 28, 2011, 11:34 a.m. UTC 
On Fri, 25 Mar 2011, Paolo Bonzini wrote:

> > Remark: disabling "newlib" (as opposed to target-newlib) for a host seems
> > odd, as does disabling "libffi".  So maybe the code disabling directories
> > for host can be simplified even more.
> 
> Yes, newlib and libffi should never be built as host modules anyway.
> 
> $ grep all-newlib ../../Makefile.in
> $

In that case, OK to commit this patch (cleaning up settings that as 
discussed should never have any effect anyway)?

2011-03-28  Joseph Myers  <joseph@codesourcery.com>

	* configure.ac (i[[3456789]]86-*-msdosdjgpp*): Don't disable
	libffi on host.
	(x86_64-*-mingw*, i[[3456789]]86-*-mingw32*): Don't disable newlib
	on host.
	(c54x*-*-* | tic54x-*-*): Don't disable newlib on target.
	* configure: Regenerate.

Comments

Paolo Bonzini March 28, 2011, 11:37 a.m. UTC | #1 
On 03/28/2011 01:34 PM, Joseph S. Myers wrote:
> 2011-03-28  Joseph Myers<joseph@codesourcery.com>
>
> 	* configure.ac (i[[3456789]]86-*-msdosdjgpp*): Don't disable
> 	libffi on host.
> 	(x86_64-*-mingw*, i[[3456789]]86-*-mingw32*): Don't disable newlib
> 	on host.
> 	(c54x*-*-* | tic54x-*-*): Don't disable newlib on target.

This should be "don't disable newlib on host".

Otherwise ok, thanks.

Paolo
diff mbox

Patch

Index: configure.ac
===================================================================
--- configure.ac	(revision 171601)
+++ configure.ac	(working copy)
@@ -422,14 +422,8 @@ 
 
 case "${host}" in
   i[[3456789]]86-*-msdosdjgpp*)
-    noconfigdirs="$noconfigdirs tcl tk itcl libffi"
+    noconfigdirs="$noconfigdirs tcl tk itcl"
     ;;
-  x86_64-*-mingw*)
-    noconfigdirs="$noconfigdirs newlib"
-    ;;
-  i[[3456789]]86-*-mingw32*)
-    noconfigdirs="$noconfigdirs newlib"
-    ;;
 esac
 
 
@@ -680,7 +674,7 @@ 
     noconfigdirs="$noconfigdirs target-libstdc++-v3 target-libgloss ${libgcj}"
     ;;
   c54x*-*-* | tic54x-*-*)
-    noconfigdirs="$noconfigdirs target-libstdc++-v3 target-libgloss ${libgcj} gcc gdb newlib"
+    noconfigdirs="$noconfigdirs target-libstdc++-v3 target-libgloss ${libgcj} gcc gdb"
     ;;
   cr16-*-*)
     noconfigdirs="$noconfigdirs ${libgcj} gdb"