[1/1] libglib2: bump to 2.56.0

Message ID 20180314110224.32587-1-aduskett@gmail.com
State Accepted
Headers show
Series
  • [1/1] libglib2: bump to 2.56.0
Related show

Commit Message

Adam Duskett March 14, 2018, 11:02 a.m.
Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
 package/libglib2/libglib2.hash | 4 ++--
 package/libglib2/libglib2.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Thomas Petazzoni April 6, 2018, 8:22 p.m. | #1
Hello,

On Wed, 14 Mar 2018 07:02:24 -0400, Adam Duskett wrote:
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
>  package/libglib2/libglib2.hash | 4 ++--
>  package/libglib2/libglib2.mk   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
Thomas Petazzoni April 7, 2018, 11:40 a.m. | #2
Hello Adam,

On Fri, 6 Apr 2018 22:22:53 +0200, Thomas Petazzoni wrote:

> On Wed, 14 Mar 2018 07:02:24 -0400, Adam Duskett wrote:
> > Signed-off-by: Adam Duskett <aduskett@gmail.com>
> > ---
> >  package/libglib2/libglib2.hash | 4 ++--
> >  package/libglib2/libglib2.mk   | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)  
> 
> Applied to master, thanks.

So I have to say I am not happy. At all.

Once again, you have contributed a package update without even testing
it with what is the default Buildroot situation: a uClibc toolchain.
This has turned the autobuilders all red since I pushed your commit.

You asked on IRC the other day why your libglib2 update hadn't been
applied. Now you know why: because you regularly break the build in a
way that shows that the testing has clearly been insufficient.

I don't require anyone to test all the reverse dependencies of a
package being updated, especially for a package such as libglib2 that
has gazillions of reverse dependencies. But here you didn't even test
building libglib2 itself with a regular uClibc toolchain. I'm not
talking about a weird case, on a weird CPU architecture, but I'm
talking about the very basic case of building libglib2 with uClibc.

So for me, things are clear: from now, I will no longer merge any
new package or version bump from you if it doesn't come with a
test-pkg output that shows it has been tested with the 6 "main"
configurations that we test by default in test-pkg.

In the mean time, I have fixed the libglib2 by backporting an upstream
commit:

  https://git.buildroot.org/buildroot/commit/?id=bd90def0ded4b71dbc40b78b8b4dacba32687885

Best regards,

Thomas

Patch

diff --git a/package/libglib2/libglib2.hash b/package/libglib2/libglib2.hash
index cf1c9557f8..b957bf4b10 100644
--- a/package/libglib2/libglib2.hash
+++ b/package/libglib2/libglib2.hash
@@ -1,4 +1,4 @@ 
-# https://download.gnome.org/sources/glib/2.54/glib-2.54.2.sha256sum
-sha256  bb89e5c5aad33169a8c7f28b45671c7899c12f74caf707737f784d7102758e6c  glib-2.54.2.tar.xz
+# https://download.gnome.org/sources/glib/2.56/glib-2.56.0.sha256sum
+sha256  ecef6e17e97b8d9150d0e8a4b3edee1ac37331213b8a2a87a083deea408a0fc7  glib-2.56.0.tar.xz
 # License files, locally calculated
 sha256	dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING
diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
index 097c980393..41ec7ee377 100644
--- a/package/libglib2/libglib2.mk
+++ b/package/libglib2/libglib2.mk
@@ -4,8 +4,8 @@ 
 #
 ################################################################################
 
-LIBGLIB2_VERSION_MAJOR = 2.54
-LIBGLIB2_VERSION = $(LIBGLIB2_VERSION_MAJOR).2
+LIBGLIB2_VERSION_MAJOR = 2.56
+LIBGLIB2_VERSION = $(LIBGLIB2_VERSION_MAJOR).0
 LIBGLIB2_SOURCE = glib-$(LIBGLIB2_VERSION).tar.xz
 LIBGLIB2_SITE = http://ftp.gnome.org/pub/gnome/sources/glib/$(LIBGLIB2_VERSION_MAJOR)
 LIBGLIB2_LICENSE = LGPL-2.0+