From patchwork Wed Mar 14 07:37:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 885630 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="o4Yri9PQ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 401Nz12Yyyz9sV5 for ; Wed, 14 Mar 2018 18:44:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753329AbeCNHo2 (ORCPT ); Wed, 14 Mar 2018 03:44:28 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:33730 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbeCNHo1 (ORCPT ); Wed, 14 Mar 2018 03:44:27 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2E7b7sG094506; Wed, 14 Mar 2018 07:44:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=4DI5mOKr1gwb5X8K5X17mB8hRC6uLg8dDZmMMuuIoSY=; b=o4Yri9PQrE4k3PWuOWeATz3UuDrzoHRc47z8AdBzZfrGsdzZ9BH/XjT4GGC4u5jFGgjd 7ktbGL3fDzgT6XnE3PA7Cshpc/f/KE4HbLHMk4/egLb2YVz5Bqq+aoSNNy25BluN7BkZ mU5tIttX1x8arPB590NXx/vEtnOSnmDfP++YBjcRqzy+EKgBoBp0bELhJa4a1hd99mEW a3eEqXZjy+YrpmZdeu8G8D32f/D+Pe/rwdja9V6PXEVPGa+FTm/qJlQZUx2nZp5pPv2U vWzzcxI0cFNm3nmyeVE/t0aDtVKs/YWegESJQCD3Ub1J1mrtDaTOPVgTLkX+hxjZUwyG Tw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2gpyg001nt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Mar 2018 07:44:04 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2E7bS5x019679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Mar 2018 07:37:29 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w2E7bR9C022895; Wed, 14 Mar 2018 07:37:28 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 14 Mar 2018 00:37:26 -0700 Date: Wed, 14 Mar 2018 10:37:19 +0300 From: Dan Carpenter To: Alessandro Zummo , Patrick Bruenn Cc: Alexandre Belloni , linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] rtc: mxc_v2: unlock on error in mxc_rtc_set_alarm() Message-ID: <20180314073719.GA2470@mwanda> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.3 (2018-01-21) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8831 signatures=668690 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803140089 Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org We need to unlock if time is more than U32_MAX. Fixes: 83c880f79e88 ("rtc: add mxc driver for i.MX53 SRTC") Signed-off-by: Dan Carpenter diff --git a/drivers/rtc/rtc-mxc_v2.c b/drivers/rtc/rtc-mxc_v2.c index 9e14efb990b2..90c9ab68688f 100644 --- a/drivers/rtc/rtc-mxc_v2.c +++ b/drivers/rtc/rtc-mxc_v2.c @@ -243,12 +243,14 @@ static int mxc_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) { const time64_t time = rtc_tm_to_time64(&alrm->time); struct mxc_rtc_data *pdata = dev_get_drvdata(dev); - int ret = mxc_rtc_lock(pdata); + int ret; + ret = mxc_rtc_lock(pdata); if (ret) return ret; if (time > U32_MAX) { + mxc_rtc_unlock(pdata); dev_err(dev, "Hopefully I am out of service by then :-(\n"); return -EINVAL; }