[U-Boot,v4,01/19] sunxi: README.sunxi64: Add hint about non-debug of ARM Trusted Firmware

Message ID 20180314015715.15615-2-andre.przywara@arm.com
State Changes Requested
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series
  • sunxi: sync H3, H5, A64 DTs from mainline Linux
Related show

Commit Message

Andre Przywara March 14, 2018, 1:56 a.m.
As we are running into issues where the final U-Boot FIT image file is
exceeding our size limit, add a hint to the README.sunxi64 file
to point out the possibility of building non-debug versions of the ATF
binary. These are about 12KB smaller than the standard debug build, and
so allow successful U-Boot builds for many boards with the Allwinner H5
SoC.
Please note that under normal circumstances the debug build is still
recommended, as it gives valuable clues in case something goes wrong in
the ATF.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 board/sunxi/README.sunxi64 | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jagan Teki March 21, 2018, 6:40 p.m. | #1
On Wed, Mar 14, 2018 at 7:26 AM, Andre Przywara <andre.przywara@arm.com> wrote:
> As we are running into issues where the final U-Boot FIT image file is
> exceeding our size limit, add a hint to the README.sunxi64 file
> to point out the possibility of building non-debug versions of the ATF
> binary. These are about 12KB smaller than the standard debug build, and
> so allow successful U-Boot builds for many boards with the Allwinner H5
> SoC.
> Please note that under normal circumstances the debug build is still
> recommended, as it gives valuable clues in case something goes wrong in
> the ATF.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  board/sunxi/README.sunxi64 | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/board/sunxi/README.sunxi64 b/board/sunxi/README.sunxi64
> index 5a363d27b8..df1dbc818f 100644
> --- a/board/sunxi/README.sunxi64
> +++ b/board/sunxi/README.sunxi64
> @@ -38,6 +38,12 @@ the root of your U-Boot build directory (or create a symbolic link).
>  $ export BL31=/src/arm-trusted-firmware/build/sun50iw1p1/debug/bl31.bin
>    (adjust the actual path accordingly)
>
> +If you run into size issues with the resulting U-Boot image file, it might
> +help to use a release build, by using "DEBUG=0" when building bl31.bin.

I thought I've commented this in previous version patch, w/o DEBUG=0
can also build release right? like

make PLAT=sun50iw1p1 bl31
Andre Przywara March 21, 2018, 7:03 p.m. | #2
Hi,

On 21/03/18 18:40, Jagan Teki wrote:
> On Wed, Mar 14, 2018 at 7:26 AM, Andre Przywara <andre.przywara@arm.com> wrote:
>> As we are running into issues where the final U-Boot FIT image file is
>> exceeding our size limit, add a hint to the README.sunxi64 file
>> to point out the possibility of building non-debug versions of the ATF
>> binary. These are about 12KB smaller than the standard debug build, and
>> so allow successful U-Boot builds for many boards with the Allwinner H5
>> SoC.
>> Please note that under normal circumstances the debug build is still
>> recommended, as it gives valuable clues in case something goes wrong in
>> the ATF.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>> ---
>>  board/sunxi/README.sunxi64 | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/board/sunxi/README.sunxi64 b/board/sunxi/README.sunxi64
>> index 5a363d27b8..df1dbc818f 100644
>> --- a/board/sunxi/README.sunxi64
>> +++ b/board/sunxi/README.sunxi64
>> @@ -38,6 +38,12 @@ the root of your U-Boot build directory (or create a symbolic link).
>>  $ export BL31=/src/arm-trusted-firmware/build/sun50iw1p1/debug/bl31.bin
>>    (adjust the actual path accordingly)
>>
>> +If you run into size issues with the resulting U-Boot image file, it might
>> +help to use a release build, by using "DEBUG=0" when building bl31.bin.
> 
> I thought I've commented this in previous version patch, w/o DEBUG=0
> can also build release right? like
> 
> make PLAT=sun50iw1p1 bl31

Yes, DEBUG=0 is the (current) default in the Makefile. But what's the
question? The original recipe said DEBUG=1, so stating DEBUG=0 makes it
obvious what to change. Given that with DEBUG not defined to 1, ATF is
*completely* silent, I would very much like to encourage people to use
DEBUG builds, and just suggesting DEBUG=0 as a workaround.

Cheers,
Andre.
Jagan Teki March 21, 2018, 7:08 p.m. | #3
On Thu, Mar 22, 2018 at 12:33 AM, André Przywara <andre.przywara@arm.com> wrote:
> Hi,
>
> On 21/03/18 18:40, Jagan Teki wrote:
>> On Wed, Mar 14, 2018 at 7:26 AM, Andre Przywara <andre.przywara@arm.com> wrote:
>>> As we are running into issues where the final U-Boot FIT image file is
>>> exceeding our size limit, add a hint to the README.sunxi64 file
>>> to point out the possibility of building non-debug versions of the ATF
>>> binary. These are about 12KB smaller than the standard debug build, and
>>> so allow successful U-Boot builds for many boards with the Allwinner H5
>>> SoC.
>>> Please note that under normal circumstances the debug build is still
>>> recommended, as it gives valuable clues in case something goes wrong in
>>> the ATF.
>>>
>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>>> ---
>>>  board/sunxi/README.sunxi64 | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/board/sunxi/README.sunxi64 b/board/sunxi/README.sunxi64
>>> index 5a363d27b8..df1dbc818f 100644
>>> --- a/board/sunxi/README.sunxi64
>>> +++ b/board/sunxi/README.sunxi64
>>> @@ -38,6 +38,12 @@ the root of your U-Boot build directory (or create a symbolic link).
>>>  $ export BL31=/src/arm-trusted-firmware/build/sun50iw1p1/debug/bl31.bin
>>>    (adjust the actual path accordingly)
>>>
>>> +If you run into size issues with the resulting U-Boot image file, it might
>>> +help to use a release build, by using "DEBUG=0" when building bl31.bin.
>>
>> I thought I've commented this in previous version patch, w/o DEBUG=0
>> can also build release right? like
>>
>> make PLAT=sun50iw1p1 bl31
>
> Yes, DEBUG=0 is the (current) default in the Makefile. But what's the
> question? The original recipe said DEBUG=1, so stating DEBUG=0 makes it
> obvious what to change. Given that with DEBUG not defined to 1, ATF is
> *completely* silent, I would very much like to encourage people to use
> DEBUG builds, and just suggesting DEBUG=0 as a workaround.

My question is without mentioning any DEBUG just build like this

make PLAT=sun50iw1p1 bl31

will be similar to

make PLAT=sun50iw1p1 DEBUG=0 bl31

right?
Andre Przywara March 21, 2018, 7:23 p.m. | #4
On 21/03/18 19:08, Jagan Teki wrote:
> On Thu, Mar 22, 2018 at 12:33 AM, André Przywara <andre.przywara@arm.com> wrote:
>> Hi,
>>
>> On 21/03/18 18:40, Jagan Teki wrote:
>>> On Wed, Mar 14, 2018 at 7:26 AM, Andre Przywara <andre.przywara@arm.com> wrote:
>>>> As we are running into issues where the final U-Boot FIT image file is
>>>> exceeding our size limit, add a hint to the README.sunxi64 file
>>>> to point out the possibility of building non-debug versions of the ATF
>>>> binary. These are about 12KB smaller than the standard debug build, and
>>>> so allow successful U-Boot builds for many boards with the Allwinner H5
>>>> SoC.
>>>> Please note that under normal circumstances the debug build is still
>>>> recommended, as it gives valuable clues in case something goes wrong in
>>>> the ATF.
>>>>
>>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>>> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>>>> ---
>>>>  board/sunxi/README.sunxi64 | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/board/sunxi/README.sunxi64 b/board/sunxi/README.sunxi64
>>>> index 5a363d27b8..df1dbc818f 100644
>>>> --- a/board/sunxi/README.sunxi64
>>>> +++ b/board/sunxi/README.sunxi64
>>>> @@ -38,6 +38,12 @@ the root of your U-Boot build directory (or create a symbolic link).
>>>>  $ export BL31=/src/arm-trusted-firmware/build/sun50iw1p1/debug/bl31.bin
>>>>    (adjust the actual path accordingly)
>>>>
>>>> +If you run into size issues with the resulting U-Boot image file, it might
>>>> +help to use a release build, by using "DEBUG=0" when building bl31.bin.
>>>
>>> I thought I've commented this in previous version patch, w/o DEBUG=0
>>> can also build release right? like
>>>
>>> make PLAT=sun50iw1p1 bl31
>>
>> Yes, DEBUG=0 is the (current) default in the Makefile. But what's the
>> question? The original recipe said DEBUG=1, so stating DEBUG=0 makes it
>> obvious what to change. Given that with DEBUG not defined to 1, ATF is
>> *completely* silent, I would very much like to encourage people to use
>> DEBUG builds, and just suggesting DEBUG=0 as a workaround.
> 
> My question is without mentioning any DEBUG just build like this
> 
> make PLAT=sun50iw1p1 bl31
> 
> will be similar to
> 
> make PLAT=sun50iw1p1 DEBUG=0 bl31

Yes, that's what I said above. The Makefile in the ATF root directory
sets DEBUG to 0, if not overridden on the make command line.

Cheers,
Andre.

Patch

diff --git a/board/sunxi/README.sunxi64 b/board/sunxi/README.sunxi64
index 5a363d27b8..df1dbc818f 100644
--- a/board/sunxi/README.sunxi64
+++ b/board/sunxi/README.sunxi64
@@ -38,6 +38,12 @@  the root of your U-Boot build directory (or create a symbolic link).
 $ export BL31=/src/arm-trusted-firmware/build/sun50iw1p1/debug/bl31.bin
   (adjust the actual path accordingly)
 
+If you run into size issues with the resulting U-Boot image file, it might
+help to use a release build, by using "DEBUG=0" when building bl31.bin.
+As sometimes the ATF build process is a bit picky about the toolchain used,
+or if you can't be bothered with building ATF, there are known working
+binaries in the firmware repository[3], purely for convenience reasons.
+
  SPL/U-Boot
 ------------
 Both U-Boot proper and the SPL are using the 64-bit mode. As the boot ROM