[pci,v6,2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

Message ID 20180313212855.3553.97762.stgit@localhost.localdomain
State Superseded
Delegated to: Bjorn Helgaas
Headers show
  • Add support for unmanaged SR-IOV
Related show

Commit Message

Alexander Duyck March 13, 2018, 9:29 p.m.
From: Alexander Duyck <alexander.h.duyck@intel.com>

Hardware-realized virtio_pci devices can implement SR-IOV, so this
patch enables its use. The device in question is an upcoming Intel
NIC that implements both a virtio_net PF and virtio_net VFs. These
are hardware realizations of what has been up to now been a software

The device in question has the following 4-part PCI IDs:

PF: vendor: 1af4 device: 1041 subvendor: 8086 subdevice: 15fe
VF: vendor: 1af4 device: 1041 subvendor: 8086 subdevice: 05fe

The patch currently needs no check for device ID, because the callback
will never be made for devices that do not assert the capability or
when run on a platform incapable of SR-IOV.

One reason for this patch is because the hardware requires the
vendor ID of a VF to be the same as the vendor ID of the PF that
created it. So it seemed logical to simply have a fully-functioning
virtio_net PF create the VFs. This patch makes that possible.

Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>

v4: Dropped call to pci_disable_sriov in virtio_pci_remove function
v5: Replaced call to pci_sriov_configure_unmanaged with
v6: Dropped "#ifdef" checks for IOV wrapping sriov_configure definition

 drivers/virtio/virtio_pci_common.c |    1 +
 1 file changed, 1 insertion(+)


Christoph Hellwig March 14, 2018, 8:54 a.m. | #1
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>


diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
index 48d4d1cf1cb6..67a227fd7aa0 100644
--- a/drivers/virtio/virtio_pci_common.c
+++ b/drivers/virtio/virtio_pci_common.c
@@ -596,6 +596,7 @@  static void virtio_pci_remove(struct pci_dev *pci_dev)
 	.driver.pm	= &virtio_pci_pm_ops,
+	.sriov_configure = pci_sriov_configure_simple,