[iproute2,1/1] tc: use get_u32() in psample action to match types

Message ID 1520975783-8593-1-git-send-email-mrv@mojatatu.com
State Accepted
Delegated to: stephen hemminger
Headers show
Series
  • [iproute2,1/1] tc: use get_u32() in psample action to match types
Related show

Commit Message

Roman Mashak March 13, 2018, 9:16 p.m.
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
---
 tc/m_sample.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

yotam gigi March 14, 2018, 5:41 a.m. | #1
On Tue, Mar 13, 2018 at 11:16 PM, Roman Mashak <mrv@mojatatu.com> wrote:

Makes sense :)

Acked-by: Yotam Gigi <yotam.gi@gmail.com>

> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> ---
>  tc/m_sample.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tc/m_sample.c b/tc/m_sample.c
> index ff5ee6bd1ef6..dff986f59999 100644
> --- a/tc/m_sample.c
> +++ b/tc/m_sample.c
> @@ -65,7 +65,7 @@ static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
>         while (argc > 0) {
>                 if (matches(*argv, "rate") == 0) {
>                         NEXT_ARG();
> -                       if (get_unsigned(&rate, *argv, 10) != 0) {
> +                       if (get_u32(&rate, *argv, 10) != 0) {
>                                 fprintf(stderr, "Illegal rate %s\n", *argv);
>                                 usage();
>                                 return -1;
> @@ -73,7 +73,7 @@ static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
>                         rate_set = true;
>                 } else if (matches(*argv, "group") == 0) {
>                         NEXT_ARG();
> -                       if (get_unsigned(&group, *argv, 10) != 0) {
> +                       if (get_u32(&group, *argv, 10) != 0) {
>                                 fprintf(stderr, "Illegal group num %s\n",
>                                         *argv);
>                                 usage();
> @@ -82,7 +82,7 @@ static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
>                         group_set = true;
>                 } else if (matches(*argv, "trunc") == 0) {
>                         NEXT_ARG();
> -                       if (get_unsigned(&trunc, *argv, 10) != 0) {
> +                       if (get_u32(&trunc, *argv, 10) != 0) {
>                                 fprintf(stderr, "Illegal truncation size %s\n",
>                                         *argv);
>                                 usage();
> --
> 2.7.4
>
Stephen Hemminger March 16, 2018, 8:40 p.m. | #2
On Tue, 13 Mar 2018 17:16:23 -0400
Roman Mashak <mrv@mojatatu.com> wrote:

> Signed-off-by: Roman Mashak <mrv@mojatatu.com>


Applied

Patch

diff --git a/tc/m_sample.c b/tc/m_sample.c
index ff5ee6bd1ef6..dff986f59999 100644
--- a/tc/m_sample.c
+++ b/tc/m_sample.c
@@ -65,7 +65,7 @@  static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
 	while (argc > 0) {
 		if (matches(*argv, "rate") == 0) {
 			NEXT_ARG();
-			if (get_unsigned(&rate, *argv, 10) != 0) {
+			if (get_u32(&rate, *argv, 10) != 0) {
 				fprintf(stderr, "Illegal rate %s\n", *argv);
 				usage();
 				return -1;
@@ -73,7 +73,7 @@  static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
 			rate_set = true;
 		} else if (matches(*argv, "group") == 0) {
 			NEXT_ARG();
-			if (get_unsigned(&group, *argv, 10) != 0) {
+			if (get_u32(&group, *argv, 10) != 0) {
 				fprintf(stderr, "Illegal group num %s\n",
 					*argv);
 				usage();
@@ -82,7 +82,7 @@  static int parse_sample(struct action_util *a, int *argc_p, char ***argv_p,
 			group_set = true;
 		} else if (matches(*argv, "trunc") == 0) {
 			NEXT_ARG();
-			if (get_unsigned(&trunc, *argv, 10) != 0) {
+			if (get_u32(&trunc, *argv, 10) != 0) {
 				fprintf(stderr, "Illegal truncation size %s\n",
 					*argv);
 				usage();