| Message ID | 20110327110126.GA25595@gondor.apana.org.au |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> mlx4_en: Fix loss of promiscuity > > The mlx4_en driver uses the combination stop_port/start_port in a number of places. Unfortunately that causes any promiscuous mode settings on the hardware to be lost. > > This patch fixes that problem. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> > Thank you Herbert, This patch does fix the problem you reported on. Thanks, Yevgeny -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il> Date: Sun, 27 Mar 2011 11:21:37 +0000 >> mlx4_en: Fix loss of promiscuity >> >> The mlx4_en driver uses the combination stop_port/start_port in a number of places. Unfortunately that causes any promiscuous mode settings on the hardware to be lost. >> >> This patch fixes that problem. >> >> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> >> > > Thank you Herbert, > This patch does fix the problem you reported on. Please ACK patches explicitly by stating: Acked-by: ... in your reply so that your feedback automatically ends up in the tree when I apply his patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Sun, 27 Mar 2011 19:01:26 +0800 > mlx4_en: Fix loss of promiscuity > > The mlx4_en driver uses the combination stop_port/start_port > in a number of places. Unfortunately that causes any promiscuous > mode settings on the hardware to be lost. > > This patch fixes that problem. > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Applied, thanks Herbert. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c index 5762ebd..4f158ba 100644 --- a/drivers/net/mlx4/en_netdev.c +++ b/drivers/net/mlx4/en_netdev.c @@ -742,6 +742,9 @@ int mlx4_en_start_port(struct net_device *dev) 0, MLX4_PROT_ETH)) mlx4_warn(mdev, "Failed Attaching Broadcast\n"); + /* Must redo promiscuous mode setup. */ + priv->flags &= ~(MLX4_EN_FLAG_PROMISC | MLX4_EN_FLAG_MC_PROMISC); + /* Schedule multicast task to populate multicast list */ queue_work(mdev->workqueue, &priv->mcast_task);
Hi: mlx4_en: Fix loss of promiscuity The mlx4_en driver uses the combination stop_port/start_port in a number of places. Unfortunately that causes any promiscuous mode settings on the hardware to be lost. This patch fixes that problem. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Thanks,