Patchwork Change in inline keyword usage.

login
register
mail settings
Submitter Balaji G
Date March 27, 2011, 8:48 a.m.
Message ID <1301215710-8112-1-git-send-email-balajig81@gmail.com>
Download mbox | patch
Permalink /patch/88502/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Balaji G - March 27, 2011, 8:48 a.m.
Signed-off-by: G.Balaji <balajig81@gmail.com>
---
 drivers/net/bnx2.c |    2 +-
 drivers/net/tg3.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
David Miller - March 28, 2011, 1:41 a.m.
From: "G.Balaji" <balajig81@gmail.com>
Date: Sun, 27 Mar 2011 14:18:30 +0530

> 
> Signed-off-by: G.Balaji <balajig81@gmail.com>

The tg3.c case was already taken care of by another patch
submission, please resend this patch with just the other
portion and please write a better commit message.

"Change in inline keyword usage" doesn't tell us anything.

What are you changing?  Why are you changing it?  What subsystem
are you making these changes in?

F.e. a better submission would be:

--------------------
Subject: [PATCH] drivers net: Fix declaration ordering in inline functions.

It should be "static inline foo" instead of "static foo inline."

Signed-off-by: ...
--------------------
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index d1865cc..8e6d618 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -8317,7 +8317,7 @@  static const struct net_device_ops bnx2_netdev_ops = {
 #endif
 };
 
-static void inline vlan_features_add(struct net_device *dev, u32 flags)
+static inline void vlan_features_add(struct net_device *dev, u32 flags)
 {
 	dev->vlan_features |= flags;
 }
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index ebec888..bddcf25 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -13118,7 +13118,7 @@  done:
 
 static struct pci_dev * __devinit tg3_find_peer(struct tg3 *);
 
-static void inline vlan_features_add(struct net_device *dev, unsigned long flags)
+static inline void vlan_features_add(struct net_device *dev, unsigned long flags)
 {
 	dev->vlan_features |= flags;
 }