| Message ID | 1301193753-10045-2-git-send-email-martinez.javier@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Mar 27, 2011 at 04:42:32AM +0200, Javier Martinez Canillas wrote: > This flag is scheduled for removal so we shouldn't used it. > > Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> > --- > drivers/net/tg3.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c > index c67eb19..58c6049 100644 > --- a/drivers/net/tg3.c > +++ b/drivers/net/tg3.c > @@ -8844,12 +8844,11 @@ static int tg3_request_irq(struct tg3 *tp, int irq_num) > fn = tg3_msi; > if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI) > fn = tg3_msi_1shot; > - flags = IRQF_SAMPLE_RANDOM; You need initialize flags to zero here. Apparently gcc doesn't catch this. I'm using gcc 4.4.3-4ubuntu5. regards, dan carpenter v > } else { > fn = tg3_interrupt; > if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS) > fn = tg3_interrupt_tagged; > - flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM; > + flags = IRQF_SHARED; > } > > return request_irq(tnapi->irq_vec, fn, flags, name, tnapi); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Dan Carpenter <error27@gmail.com> Date: Sun, 27 Mar 2011 06:08:30 +0300 > On Sun, Mar 27, 2011 at 04:42:32AM +0200, Javier Martinez Canillas wrote: >> This flag is scheduled for removal so we shouldn't used it. >> >> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> >> --- >> drivers/net/tg3.c | 5 ++--- >> 1 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c >> index c67eb19..58c6049 100644 >> --- a/drivers/net/tg3.c >> +++ b/drivers/net/tg3.c >> @@ -8844,12 +8844,11 @@ static int tg3_request_irq(struct tg3 *tp, int irq_num) >> fn = tg3_msi; >> if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI) >> fn = tg3_msi_1shot; >> - flags = IRQF_SAMPLE_RANDOM; > > You need initialize flags to zero here. Apparently gcc doesn't catch > this. I'm using gcc 4.4.3-4ubuntu5. Javier please fix this up and resubmit your patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index c67eb19..58c6049 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -8844,12 +8844,11 @@ static int tg3_request_irq(struct tg3 *tp, int irq_num) fn = tg3_msi; if (tp->tg3_flags2 & TG3_FLG2_1SHOT_MSI) fn = tg3_msi_1shot; - flags = IRQF_SAMPLE_RANDOM; } else { fn = tg3_interrupt; if (tp->tg3_flags & TG3_FLAG_TAGGED_STATUS) fn = tg3_interrupt_tagged; - flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM; + flags = IRQF_SHARED; } return request_irq(tnapi->irq_vec, fn, flags, name, tnapi); @@ -8880,7 +8879,7 @@ static int tg3_test_interrupt(struct tg3 *tp) } err = request_irq(tnapi->irq_vec, tg3_test_isr, - IRQF_SHARED | IRQF_SAMPLE_RANDOM, dev->name, tnapi); + IRQF_SHARED, dev->name, tnapi); if (err) return err;
This flag is scheduled for removal so we shouldn't used it. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> --- drivers/net/tg3.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)