[1/2] klog.json: change severity for AE_ALREADY_EXISTS errors

Message ID 1520881648-10317-1-git-send-email-alex.hung@canonical.com
State Accepted
Headers show
Series
  • [1/2] klog.json: change severity for AE_ALREADY_EXISTS errors
Related show

Commit Message

Alex Hung March 12, 2018, 7:07 p.m.
It is getting common to see "Namespace lookup failure,
AE_ALREADY_EXISTS" and this can break some ACPI functionalities
according to the failing objects. Changing severity to CRITICAL make
it stand out and help firmware developers to fix it.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 data/klog.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Colin King March 12, 2018, 7:08 p.m. | #1
On 12/03/18 19:07, Alex Hung wrote:
> It is getting common to see "Namespace lookup failure,
> AE_ALREADY_EXISTS" and this can break some ACPI functionalities
> according to the failing objects. Changing severity to CRITICAL make
> it stand out and help firmware developers to fix it.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index bd6178a..f138b82 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -5163,7 +5163,7 @@ atform Communications Channel Table (PCCT) and find the PCC subspace communicati
>    },
>    {
>     "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> +   "log_level": "LOG_LEVEL_CRITICAL",
>     "pattern": "ACPI Error.*Namespace lookup failure, AE_ALREADY_EXISTS",
>     "advice": "",
>     "label": "KlogAcpiNamespaceLookupFailure"
> 

Good idea.

Acked-by: Colin Ian King <colin.king@canonical.com>
ivanhu March 14, 2018, 9:22 a.m. | #2
On 03/13/2018 03:07 AM, Alex Hung wrote:
> It is getting common to see "Namespace lookup failure,
> AE_ALREADY_EXISTS" and this can break some ACPI functionalities
> according to the failing objects. Changing severity to CRITICAL make
> it stand out and help firmware developers to fix it.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   data/klog.json | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index bd6178a..f138b82 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -5163,7 +5163,7 @@ atform Communications Channel Table (PCCT) and find the PCC subspace communicati
>     },
>     {
>      "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> +   "log_level": "LOG_LEVEL_CRITICAL",
>      "pattern": "ACPI Error.*Namespace lookup failure, AE_ALREADY_EXISTS",
>      "advice": "",
>      "label": "KlogAcpiNamespaceLookupFailure"
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index bd6178a..f138b82 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -5163,7 +5163,7 @@  atform Communications Channel Table (PCCT) and find the PCC subspace communicati
   },
   {
    "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
+   "log_level": "LOG_LEVEL_CRITICAL",
    "pattern": "ACPI Error.*Namespace lookup failure, AE_ALREADY_EXISTS",
    "advice": "",
    "label": "KlogAcpiNamespaceLookupFailure"