[v3,1/2] ASoC: samsung: Snow DT bindings update

Message ID 20180312184939.11327-1-s.nawrocki@samsung.com
State Superseded, archived
Headers show
Series
  • [v3,1/2] ASoC: samsung: Snow DT bindings update
Related show

Commit Message

Sylwester Nawrocki March 12, 2018, 6:49 p.m.
The new DT bindings are introduced so sound on the HDMI interface
can also be supported. The exisiting CPU and CODEC DAI phandle
properties are marked as deprecated.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes since v2:
 - edited summary line.
---
 Documentation/devicetree/bindings/sound/snow.txt | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Comments

Sylwester Nawrocki March 12, 2018, 6:54 p.m. | #1
On 03/12/2018 07:49 PM, Sylwester Nawrocki wrote:
> This patch updates the driver so, in addition to current DT bindings, it
> also can also use the new DT bindings with cpu, codec subnodes which allow
> to support sound on the HDMI interface.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

I've forgotten to add Krzysztof's tag:

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski March 13, 2018, 7:28 a.m. | #2
On Mon, Mar 12, 2018 at 7:54 PM, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
> On 03/12/2018 07:49 PM, Sylwester Nawrocki wrote:
>> This patch updates the driver so, in addition to current DT bindings, it
>> also can also use the new DT bindings with cpu, codec subnodes which allow
>> to support sound on the HDMI interface.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> I've forgotten to add Krzysztof's tag:
>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Yes, thanks :)

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/sound/snow.txt b/Documentation/devicetree/bindings/sound/snow.txt
index 6df74f15687f..80fd9a87bb3f 100644
--- a/Documentation/devicetree/bindings/sound/snow.txt
+++ b/Documentation/devicetree/bindings/sound/snow.txt
@@ -5,8 +5,17 @@  Required properties:
 			"google,snow-audio-max98090" or
 			"google,snow-audio-max98091" or
 			"google,snow-audio-max98095"
-- samsung,i2s-controller: The phandle of the Samsung I2S controller
-- samsung,audio-codec: The phandle of the audio codec
+- samsung,i2s-controller (deprecated): The phandle of the Samsung I2S controller
+- samsung,audio-codec (deprecated): The phandle of the audio codec
+
+Required sub-nodes:
+
+ - 'cpu' subnode with a 'sound-dai' property containing the phandle of the I2S
+    controller
+ - 'codec' subnode with a 'sound-dai' property containing list of phandles
+    to the CODEC nodes, first entry must be the phandle of the MAX98090,
+    MAX98091 or MAX98095 CODEC (exact device type is indicated by the compatible
+    string) and the second entry must be the phandle of the HDMI IP block node
 
 Optional:
 - samsung,model: The name of the sound-card