Patchwork net: use CHECKSUM_NONE instead of magic number

login
register
mail settings
Submitter Cesar Eduardo Barros
Date March 26, 2011, 3:10 p.m.
Message ID <1301152230-4897-1-git-send-email-cesarb@cesarb.net>
Download mbox | patch
Permalink /patch/88465/
State Accepted
Delegated to: David Miller
Headers show

Comments

Cesar Eduardo Barros - March 26, 2011, 3:10 p.m.
Two places in the kernel were doing skb->ip_summed = 0.

Change both to skb->ip_summed = CHECKSUM_NONE, which is more readable.

Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
---
 drivers/net/ksz884x.c |    2 +-
 net/ipv6/ip6mr.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
David Miller - March 28, 2011, 1:37 a.m.
From: Cesar Eduardo Barros <cesarb@cesarb.net>
Date: Sat, 26 Mar 2011 12:10:30 -0300

> Two places in the kernel were doing skb->ip_summed = 0.
> 
> Change both to skb->ip_summed = CHECKSUM_NONE, which is more readable.
> 
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 540a8dc..7f7d570 100644
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -4898,7 +4898,7 @@  static netdev_tx_t netdev_tx(struct sk_buff *skb, struct net_device *dev)
 				goto unlock;
 			}
 			skb_copy_and_csum_dev(org_skb, skb->data);
-			org_skb->ip_summed = 0;
+			org_skb->ip_summed = CHECKSUM_NONE;
 			skb->len = org_skb->len;
 			copy_old_skb(org_skb, skb);
 		}
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index 7ff0343..29e4859 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -663,7 +663,7 @@  static int pim6_rcv(struct sk_buff *skb)
 	skb_pull(skb, (u8 *)encap - skb->data);
 	skb_reset_network_header(skb);
 	skb->protocol = htons(ETH_P_IPV6);
-	skb->ip_summed = 0;
+	skb->ip_summed = CHECKSUM_NONE;
 	skb->pkt_type = PACKET_HOST;
 
 	skb_tunnel_rx(skb, reg_dev);