rxrpc: remove redundant initialization of variable 'len'

Message ID 20180312172538.31707-1-colin.king@canonical.com
State Accepted
Delegated to: David Miller
Headers show
Series
  • rxrpc: remove redundant initialization of variable 'len'
Related show

Commit Message

Colin King March 12, 2018, 5:25 p.m.
From: Colin Ian King <colin.king@canonical.com>

The variable 'len' is being initialized with a value that is never
read and it is re-assigned later, hence the initialization is redundant
and can be removed.

Cleans up clang warning:
net/rxrpc/recvmsg.c:275:15: warning: Value stored to 'len' during its
initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/rxrpc/recvmsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller March 16, 2018, 1:49 p.m. | #1
From: Colin King <colin.king@canonical.com>
Date: Mon, 12 Mar 2018 17:25:38 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable 'len' is being initialized with a value that is never
> read and it is re-assigned later, hence the initialization is redundant
> and can be removed.
> 
> Cleans up clang warning:
> net/rxrpc/recvmsg.c:275:15: warning: Value stored to 'len' during its
> initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Hehe, if the diff provided just 2 more lines of context at the bottom
we'd be able to see the overriding assignment :-)

> @@ -272,7 +272,7 @@ static int rxrpc_locate_data(struct rxrpc_call *call, struct sk_buff *skb,
>  			     unsigned int *_offset, unsigned int *_len)
>  {
>  	unsigned int offset = sizeof(struct rxrpc_wire_header);
> -	unsigned int len = *_len;
> +	unsigned int len;
>  	int ret;
>  	u8 annotation = *_annotation;
>  
> -- 
> 2.15.1
> 

Applied, thanks Colin.

Patch

diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c
index 9d45d8b56744..7bff716e911e 100644
--- a/net/rxrpc/recvmsg.c
+++ b/net/rxrpc/recvmsg.c
@@ -272,7 +272,7 @@  static int rxrpc_locate_data(struct rxrpc_call *call, struct sk_buff *skb,
 			     unsigned int *_offset, unsigned int *_len)
 {
 	unsigned int offset = sizeof(struct rxrpc_wire_header);
-	unsigned int len = *_len;
+	unsigned int len;
 	int ret;
 	u8 annotation = *_annotation;