| Message ID | 20180312132204.23683-1-stefanha@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: add include/block/aio-wait.h | expand |
On 03/12/2018 08:22 AM, Stefan Hajnoczi wrote: > The include/block/aio-wait.h header file was added by commit > 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract > AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS. A shame checkpatch.pl and/or patchew still doesn't flag this, even though it's been proposed as a syntax check. Reviewed-by: Eric Blake <eblake@redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f409f3b158..7adc04e477 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1331,6 +1331,7 @@ F: util/aio-*.c > F: block/io.c > F: migration/block* > F: include/block/aio.h > +F: include/block/aio-wait.h > F: scripts/qemugdb/aio.py > T: git git://github.com/stefanha/qemu.git block > >
On Mon, 03/12 09:05, Eric Blake wrote: > On 03/12/2018 08:22 AM, Stefan Hajnoczi wrote: > > The include/block/aio-wait.h header file was added by commit > > 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract > > AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS. > > A shame checkpatch.pl and/or patchew still doesn't flag this, even though > it's been proposed as a syntax check. Re checkpatch.pl vs patchew, IMO this check fits better in the former. Fam
On Mon, Mar 12, 2018 at 01:22:04PM +0000, Stefan Hajnoczi wrote: > The include/block/aio-wait.h header file was added by commit > 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract > AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS. > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan
diff --git a/MAINTAINERS b/MAINTAINERS index f409f3b158..7adc04e477 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1331,6 +1331,7 @@ F: util/aio-*.c F: block/io.c F: migration/block* F: include/block/aio.h +F: include/block/aio-wait.h F: scripts/qemugdb/aio.py T: git git://github.com/stefanha/qemu.git block
The include/block/aio-wait.h header file was added by commit 7719f3c968c59e1bcda7e177679dc765b59e578f ("block: extract AIO_WAIT_WHILE() from BlockDriverState") without updating MAINTAINERS. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)