From patchwork Mon Mar 12 13:14:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Abhishek Sahu X-Patchwork-Id: 884504 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="dDDjqCw9"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dDDjqCw9"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 400JTQ4mqpz9sSN for ; Tue, 13 Mar 2018 00:18:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751431AbeCLNP1 (ORCPT ); Mon, 12 Mar 2018 09:15:27 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41606 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbeCLNPX (ORCPT ); Mon, 12 Mar 2018 09:15:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DCE5660817; Mon, 12 Mar 2018 13:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520860522; bh=aNb4xy5h2Twsh34xlWn18QIO/Ii6GU2FnQ8aBI5yA4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dDDjqCw9Kunlc15G0Lre4MolXvP7/mjtrqFsmkrv4QYl6rvFM6pjbHew9yucO3JxZ dCkSqEbLMUp0tXTMEDN4TKO1oCl82vtaox4q6mpwJ7X3d0tpYt+txwM0USUAtfpIce +rQwmu5c0uW7gBtUZwY0g9yj9VCbwu7kVEImE9gc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: absahu@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5202A605FB; Mon, 12 Mar 2018 13:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520860522; bh=aNb4xy5h2Twsh34xlWn18QIO/Ii6GU2FnQ8aBI5yA4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dDDjqCw9Kunlc15G0Lre4MolXvP7/mjtrqFsmkrv4QYl6rvFM6pjbHew9yucO3JxZ dCkSqEbLMUp0tXTMEDN4TKO1oCl82vtaox4q6mpwJ7X3d0tpYt+txwM0USUAtfpIce +rQwmu5c0uW7gBtUZwY0g9yj9VCbwu7kVEImE9gc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5202A605FB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=absahu@codeaurora.org From: Abhishek Sahu To: Andy Gross , Wolfram Sang Cc: David Brown , Sricharan R , Austin Christ , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Abhishek Sahu Subject: [PATCH v2 02/13] i2c: qup: fixed releasing dma without flush operation completion Date: Mon, 12 Mar 2018 18:44:51 +0530 Message-Id: <1520860502-14886-3-git-send-email-absahu@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1520860502-14886-1-git-send-email-absahu@codeaurora.org> References: <1520860502-14886-1-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org The QUP BSLP BAM generates the following error sometimes if the current I2C DMA transfer fails and the flush operation has been scheduled “bam-dma-engine 7884000.dma: Cannot free busy channel” If any I2C error comes during BAM DMA transfer, then the QUP I2C interrupt will be generated and the flush operation will be carried out to make I2C consume all scheduled DMA transfer. Currently, the same completion structure is being used for BAM transfer which has already completed without reinit. It will make flush operation wait_for_completion_timeout completed immediately and will proceed for freeing the DMA resources where the descriptors are still in process. Signed-off-by: Abhishek Sahu Acked-by: Sricharan R Reviewed-by: Austin Christ Reviewed-by: Andy Gross --- * Changes from v1: 1. Removed copyright and added in separate patch with SPDX license change drivers/i2c/busses/i2c-qup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index ac5edfa..75e9819 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -835,6 +835,8 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, struct i2c_msg *msg, } if (ret || qup->bus_err || qup->qup_err) { + reinit_completion(&qup->xfer); + if (qup_i2c_change_state(qup, QUP_RUN_STATE)) { dev_err(qup->dev, "change to run state timed out"); goto desc_err;