[ovs-dev,v1,1/1] Include bfd_status in ovs-vsctl show for interfaces

Message ID 1520850685-223850-1-git-send-email-majopela@redhat.com
State Accepted
Headers show
Series
  • [ovs-dev,v1,1/1] Include bfd_status in ovs-vsctl show for interfaces
Related show

Commit Message

Miguel Angel Ajo Pelayo March 12, 2018, 10:31 a.m.
Since OVS 2.8 OVN provides L3HA capabilities via BFD monitoring,
but checking the status of BFD is not obvious, and we provide
a simple way to visualize the status with this simple patch.

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
Tested-by: Miguel Angel Ajo <majopela@redhat.com>
---
 lib/db-ctl-base.h     | 2 +-
 utilities/ovs-vsctl.c | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Ben Pfaff March 14, 2018, 10:33 p.m. | #1
On Mon, Mar 12, 2018 at 10:31:25AM +0000, Miguel Angel Ajo wrote:
> Since OVS 2.8 OVN provides L3HA capabilities via BFD monitoring,
> but checking the status of BFD is not obvious, and we provide
> a simple way to visualize the status with this simple patch.
> 
> Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
> Tested-by: Miguel Angel Ajo <majopela@redhat.com>

Applied, thanks!
Miguel Angel Ajo Pelayo March 15, 2018, 9:59 a.m. | #2
Thank you Ben.

On Wed, Mar 14, 2018 at 11:34 PM Ben Pfaff <blp@ovn.org> wrote:

> On Mon, Mar 12, 2018 at 10:31:25AM +0000, Miguel Angel Ajo wrote:
> > Since OVS 2.8 OVN provides L3HA capabilities via BFD monitoring,
> > but checking the status of BFD is not obvious, and we provide
> > a simple way to visualize the status with this simple patch.
> >
> > Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
> > Tested-by: Miguel Angel Ajo <majopela@redhat.com>
>
> Applied, thanks!
>

Patch

diff --git a/lib/db-ctl-base.h b/lib/db-ctl-base.h
index eb44427..d8c4db2 100644
--- a/lib/db-ctl-base.h
+++ b/lib/db-ctl-base.h
@@ -197,7 +197,7 @@  struct weak_ref_table {
 struct cmd_show_table {
     const struct ovsdb_idl_table_class *table;
     const struct ovsdb_idl_column *name_column;
-    const struct ovsdb_idl_column *columns[3]; /* Seems like a good number. */
+    const struct ovsdb_idl_column *columns[4]; /* Seems like a good number. */
     const struct weak_ref_table wref_table;
 };
 
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 21fa18d..d55f11c 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -1018,7 +1018,8 @@  static struct cmd_show_table cmd_show_tables[] = {
      &ovsrec_interface_col_name,
      {&ovsrec_interface_col_type,
       &ovsrec_interface_col_options,
-      &ovsrec_interface_col_error},
+      &ovsrec_interface_col_error,
+      &ovsrec_interface_col_bfd_status},
      {NULL, NULL, NULL}
     },