| Message ID | 1520755147-4414-1-git-send-email-ouyzz@yealink.com |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | [v4] mtdchar: fix usage of mtd_ooblayout_ecc() | expand |
On Sun, 11 Mar 2018 15:59:07 +0800 OuYang ZhiZhong <ouyzz@yealink.com> wrote: > Section was not properly computed. The value of OOB region definition is > always ECC section 0 information in the OOB area, but we want to get all > the ECC bytes information, so we should call > mtd_ooblayout_ecc(mtd, section++, &oobregion) until it returns -ERANGE. Applied. Thanks, Boris > > Fixes: c2b78452a9db ("mtd: use mtd_ooblayout_xxx() helpers where appropriate") > Cc: <stable@vger.kernel.org> > Signed-off-by: OuYang ZhiZhong <ouyzz@yealink.com> > --- > drivers/mtd/mtdchar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c > index de8c902..7d80a8b 100644 > --- a/drivers/mtd/mtdchar.c > +++ b/drivers/mtd/mtdchar.c > @@ -479,7 +479,7 @@ static int shrink_ecclayout(struct mtd_info *mtd, > for (i = 0; i < MTD_MAX_ECCPOS_ENTRIES;) { > u32 eccpos; > > - ret = mtd_ooblayout_ecc(mtd, section, &oobregion); > + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion); > if (ret < 0) { > if (ret != -ERANGE) > return ret; > @@ -526,7 +526,7 @@ static int get_oobinfo(struct mtd_info *mtd, struct nand_oobinfo *to) > for (i = 0; i < ARRAY_SIZE(to->eccpos);) { > u32 eccpos; > > - ret = mtd_ooblayout_ecc(mtd, section, &oobregion); > + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion); > if (ret < 0) { > if (ret != -ERANGE) > return ret;
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c index de8c902..7d80a8b 100644 --- a/drivers/mtd/mtdchar.c +++ b/drivers/mtd/mtdchar.c @@ -479,7 +479,7 @@ static int shrink_ecclayout(struct mtd_info *mtd, for (i = 0; i < MTD_MAX_ECCPOS_ENTRIES;) { u32 eccpos; - ret = mtd_ooblayout_ecc(mtd, section, &oobregion); + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion); if (ret < 0) { if (ret != -ERANGE) return ret; @@ -526,7 +526,7 @@ static int get_oobinfo(struct mtd_info *mtd, struct nand_oobinfo *to) for (i = 0; i < ARRAY_SIZE(to->eccpos);) { u32 eccpos; - ret = mtd_ooblayout_ecc(mtd, section, &oobregion); + ret = mtd_ooblayout_ecc(mtd, section++, &oobregion); if (ret < 0) { if (ret != -ERANGE) return ret;
Section was not properly computed. The value of OOB region definition is always ECC section 0 information in the OOB area, but we want to get all the ECC bytes information, so we should call mtd_ooblayout_ecc(mtd, section++, &oobregion) until it returns -ERANGE. Fixes: c2b78452a9db ("mtd: use mtd_ooblayout_xxx() helpers where appropriate") Cc: <stable@vger.kernel.org> Signed-off-by: OuYang ZhiZhong <ouyzz@yealink.com> --- drivers/mtd/mtdchar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)