[v2] dt-bindings: ifc: Fix the unit address format in the examples

Message ID 1520701581-3650-1-git-send-email-festevam@gmail.com
State Changes Requested, archived
Headers show
Series
  • [v2] dt-bindings: ifc: Fix the unit address format in the examples
Related show

Commit Message

Fabio Estevam March 10, 2018, 5:06 p.m.
From: Fabio Estevam <fabio.estevam@nxp.com>

DTC warnings will be seen if these examples are used in a real dts file 
due to a mismatch in the unit address notation.

Align the unit address notation to what is done in the real dts files
as per commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit
address format warnings")

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Hi,

Commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit address
format warnings") is present in Shawn Guo's tree.

Changes since v1:
- Add a 'ifc' prefix in the Subject

 Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Shawn Guo March 12, 2018, 7:39 a.m. | #1
On Sat, Mar 10, 2018 at 02:06:21PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> DTC warnings will be seen if these examples are used in a real dts file 
> due to a mismatch in the unit address notation.
> 
> Align the unit address notation to what is done in the real dts files
> as per commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit
> address format warnings")
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring March 18, 2018, 12:48 p.m. | #2
On Sat, Mar 10, 2018 at 02:06:21PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> DTC warnings will be seen if these examples are used in a real dts file 
> due to a mismatch in the unit address notation.
> 
> Align the unit address notation to what is done in the real dts files
> as per commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit
> address format warnings")
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi,
> 
> Commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit address
> format warnings") is present in Shawn Guo's tree.

This "fix" is wrong. Memory controllers with chip selects should have 
the chip select in the unit-address. The correct fix here is you should drop 
"simple-bus".

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabio Estevam March 18, 2018, 2:03 p.m. | #3
Hi Rob,

On Sun, Mar 18, 2018 at 9:48 AM, Rob Herring <robh@kernel.org> wrote:

> This "fix" is wrong. Memory controllers with chip selects should have
> the chip select in the unit-address. The correct fix here is you should drop
> "simple-bus".

Thanks. I will revert the change and will drop "simple-bus" as suggested.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
index 89427b0..a4d4b6a 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
@@ -43,7 +43,7 @@  Example:
 			  0x1 0x0 0x0 0xffa00000 0x00010000
 			  0x3 0x0 0x0 0xffb00000 0x00020000>;
 
-		flash@0,0 {
+		flash@0 {
 			#address-cells = <1>;
 			#size-cells = <1>;
 			compatible = "cfi-flash";
@@ -58,7 +58,7 @@  Example:
 			};
 		};
 
-		flash@1,0 {
+		flash@100000000 {
 			#address-cells = <1>;
 			#size-cells = <1>;
 			compatible = "fsl,ifc-nand";
@@ -73,7 +73,7 @@  Example:
 			};
 		};
 
-		cpld@3,0 {
+		cpld@@300000000 {
 			#address-cells = <1>;
 			#size-cells = <1>;
 			compatible = "fsl,p1010rdb-cpld";