Message ID | 20180309142630.2170-1-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180309142630.2170-1-laurent@vivier.eu Subject: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180309142630.2170-1-laurent@vivier.eu -> patchew/20180309142630.2170-1-laurent@vivier.eu * [new tag] patchew/20180309143704.13420-1-kraxel@redhat.com -> patchew/20180309143704.13420-1-kraxel@redhat.com Switched to a new branch 'test' 5e3764cd71 target/m68k: implement ftentox 129d677ada target/m68k: implement ftwotox 938c4bd99b target/m68k: implement fetox 7364da0f5a target/m68k: implement flog2 7e25fb5a48 target/m68k: implement flog10 e2e2db69d6 target/m68k: implement flogn a4de7c4950 target/m68k: implement flognp1 cd93226a31 target/m68k: define floatx80_move() === OUTPUT BEGIN === Checking PATCH 1/8: target/m68k: define floatx80_move()... Checking PATCH 2/8: target/m68k: implement flognp1... ERROR: do not set execute permissions for source files #281: FILE: target/m68k/softfloat_fpsp_tables.h total: 1 errors, 0 warnings, 408 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/8: target/m68k: implement flogn... Checking PATCH 4/8: target/m68k: implement flog10... Checking PATCH 5/8: target/m68k: implement flog2... Checking PATCH 6/8: target/m68k: implement fetox... Checking PATCH 7/8: target/m68k: implement ftwotox... Checking PATCH 8/8: target/m68k: implement ftentox... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 9 March 2018 at 14:45, <no-reply@patchew.org> wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > Checking PATCH 2/8: target/m68k: implement flognp1... > ERROR: do not set execute permissions for source files > #281: FILE: target/m68k/softfloat_fpsp_tables.h > > total: 1 errors, 0 warnings, 408 lines checked Oops. Could you fix the file permissions and resend, please, Laurent ? (I don't normally worry about checkpatch issues on pull requests, but this one seems significant enough to be worth fixing.) thanks -- PMM
Le 09/03/2018 à 15:50, Peter Maydell a écrit : > On 9 March 2018 at 14:45, <no-reply@patchew.org> wrote: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: > >> Checking PATCH 2/8: target/m68k: implement flognp1... >> ERROR: do not set execute permissions for source files >> #281: FILE: target/m68k/softfloat_fpsp_tables.h >> >> total: 1 errors, 0 warnings, 408 lines checked > > Oops. Could you fix the file permissions and resend, please, > Laurent ? Yes, I'm doing that now. Thanks, Laurent