diff mbox series

[U-Boot,v2] imximage: Remove failure when no IVT offset is found

Message ID 1520594625-23884-1-git-send-email-festevam@gmail.com
State Changes Requested
Headers show
Series [U-Boot,v2] imximage: Remove failure when no IVT offset is found | expand

Commit Message

Fabio Estevam March 9, 2018, 11:23 a.m. UTC 
Sometimes imximage throws the following error:

  CFGS    board/freescale/vf610twr/imximage.cfg.cfgtmp
  CFGS    board/freescale/vf610twr/imximage.cfg.cfgtmp
  MKIMAGE u-boot-dtb.imx
Error: No BOOT_FROM tag in board/freescale/vf610twr/imximage.cfg.cfgtmp
arch/arm/mach-imx/Makefile:100: recipe for target 'u-boot-dtb.imx' failed

Later on, when running mkimage for the u-boot.imx it will succeed in
finding the IVT offset.

Looks like some race condition happening during parallel build when
processing mkimage for u-boot-dtb.imx and u-boot.imx.

A proper fix still needs to be implemented, but as a workaround let's
remove the error when the IVT offset is not found.

It is useful to have such message, especially during bring-up phase,
but the build error that it causes is severe, so better avoid the
build error for now.

The error checking can be re-implemented later when we have a proper
fix.

Reported-by: Breno Lima <breno.lima@nxp.com>
Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 tools/imximage.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/tools/imximage.c b/tools/imximage.c
index eb7e682..ed9d935 100644
--- a/tools/imximage.c
+++ b/tools/imximage.c
@@ -777,11 +777,6 @@  static uint32_t parse_cfg_file(struct imx_header *imxhdr, char *name)
 	(*set_dcd_rst)(imxhdr, dcd_len, name, lineno);
 	fclose(fd);
 
-	/* Exit if there is no BOOT_FROM field specifying the flash_offset */
-	if (imximage_ivt_offset == FLASH_OFFSET_UNDEFINED) {
-		fprintf(stderr, "Error: No BOOT_FROM tag in %s\n", name);
-		exit(EXIT_FAILURE);
-	}
 	return dcd_len;
 }