From patchwork Fri Mar 9 10:50:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 883565 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TZggoMjJ"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RMdgRopx"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zyPNz2d5Bz9sXd for ; Fri, 9 Mar 2018 21:53:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=zRMKQWGtt099qYj4MtK9+pZWo5ztYcJa6z4WoSv8uY8=; b=TZggoMjJ+MaXtJ/mo6rE0pCY8q Ynq9bSvsnOEIgic1w0r5fcca7EhoZFn9RIl5kzRmXsBX7w1N4ixFxB7y77aGSNOnAr3ltszIoNPCX ONxSq1oKY/PJnHXK6UzDGAS3PKM22+B9p6Yqu3u4U5h/Xzqpwua6TIaVTu+fe+LQp0/rAMbMc9GiJ IPM0lA7TlnGl5iIR0x1Df8jMnyqNGO8p8TZXPJBlu0fEKlRZfxKpgws/GSfOLXOZnHNtV+Bq5jDFn cuH6jrfGX8O5SKUyriR5fOH31NNkKGOS/jgSKJ1t4ZR4zIdisfJZduWzPqcGXs1+0Dd4DG/7pLrvs yXkCUQLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1euFe1-0000bE-Di; Fri, 09 Mar 2018 10:53:01 +0000 Received: from mail-io0-x241.google.com ([2607:f8b0:4001:c06::241]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1euFd5-0008KJ-5O for linux-mtd@lists.infradead.org; Fri, 09 Mar 2018 10:52:05 +0000 Received: by mail-io0-x241.google.com with SMTP id m22so3088604iob.12 for ; Fri, 09 Mar 2018 02:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=FMdmTQA82QthzdVHs0oGIWkI6uIXp3lW+XLBy/7esnc=; b=RMdgRopxb9g0RMycf1pz0uQFNGmtV/iyCQdAXiKYZYhBEEIDCuAyprlHdT52pjrsRG Ki2xUKYmJQtJwkAAtyWPcFRITuGTb0YBt+p4CoS3M5/dFpJR6uq+4quFciTiuaPK73BN xtj+0Gsam1wOq/KFufwLq8GM6XHhX673tTetewPi55xitI11UOR2LRMiFGzZTvZpHe7Z lhti6pAcot8Zk4fgCXBZccL1HIg/CuXJa6VUrv0XGLYlSjaDGYRbzCjno9rq+sOoTCXF a48wjcNlhYPxK9lQJvSgSpXGQcWYn3+VfsknPECVubOYHk/BEyIrKO+4N+dkL8ebkRCu ZMTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=FMdmTQA82QthzdVHs0oGIWkI6uIXp3lW+XLBy/7esnc=; b=f1iVyT93O7j/mGp1yjAMpcHVdDMVjZgXiYOz5kXGt92G46kNPIfo494B/qHSKRncSF 0cZk6ziT3Kg7r1Cydj7y5sTC5TheU/SnTeZAYquY9rXDCCs6+yu9VfLlrz7oBTxR7wca pwENUHx7TpA0z7ZhEeJlkaeWmJdXlUX8d8g0mycZiXCKdAOH43MIILijX6Go5WyinMUh PoGPQh+yENY4QLWyvVHp9E8QtZPrKZYbTZADVMfXflYbCaxPZ3yLy6+rHEzdkjk2qLxn urvatRZgPAj5x3jeafkcOSbZTsAzr1GE6Jme2UbCL4QI94jXLwhuEf9UqEaCS8dqFy4H 4q0w== X-Gm-Message-State: AElRT7HO7DxGahLsisaaPRUHbu1Z53IC4QwGpOClqjr7kQydaok58K2P 7o7bTb4Jc1XI5CKhhwWdkyA= X-Google-Smtp-Source: AG47ELvuSXEEFbAw31YtN95ADF8woQk9KXMA2FcivS0TSzvB/s0LHxjMTsVqaNzPBiWSNLgqtQVABg== X-Received: by 10.107.112.21 with SMTP id l21mr36162163ioc.80.1520592712268; Fri, 09 Mar 2018 02:51:52 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id y4sm739890ioi.45.2018.03.09.02.51.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 02:51:51 -0800 (PST) From: Arvind Yadav To: dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, dedekind1@gmail.com Subject: [PATCH 2/2] mtd: ubi: use put_device() if device_register fail Date: Fri, 9 Mar 2018 16:20:49 +0530 Message-Id: <5d9b08afdad2fbc65bac48d8ae22f4925bb80512.1520592440.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180309_025203_341635_609AA5C6 X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4001:c06:0:0:0:241 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arvind.yadav.cs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/mtd/ubi/vmt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c index 3fd8d7f..db85b68 100644 --- a/drivers/mtd/ubi/vmt.c +++ b/drivers/mtd/ubi/vmt.c @@ -609,6 +609,7 @@ int ubi_add_volume(struct ubi_device *ubi, struct ubi_volume *vol) return err; out_cdev: + put_device(&vol->dev); cdev_del(&vol->cdev); return err; }