| Message ID | 1520568974-15547-4-git-send-email-matheus@castello.eng.br |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | None | expand |
Hi Matheus, > Matheus Castello <matheus@castello.eng.br> hat am 9. März 2018 um 05:16 geschrieben: > > > Now we have generic pin configuration and multiplexing support, > ahd shoud be preferred than brcm legacy one. i suspect this patch won't get noticed by the DT maintainer because of the wrong subject. Please try something like this: dt-bindings: pinctrl: bcm2835-gpio: Add generic pinctrl support Even this sounds strange to you, but this patch must be the first patch of series (1/3). Stefan > > Signed-off-by: Matheus Castello <matheus@castello.eng.br> > --- > .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > index 2569866..58b4720 100644 > --- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > @@ -36,6 +36,25 @@ listed. In other words, a subnode that lists only a mux function implies no > information about any pull configuration. Similarly, a subnode that lists only > a pul parameter implies no information about the mux function. > > +This driver supports the generic pin multiplexing and configuration > +bindings. For details on each properties, you can refer to > +./pinctrl-bindings.txt. > + > +Required sub-node properties: > + - pins > + - function > + > +Optional sub-node properties: > + - bias-disable > + - bias-pull-up > + - bias-pull-down > + - output-high > + - output-low > + > +Legacy pin configuration and multiplexing binding: > +*** (Its use is deprecated, use generic multiplexing and configuration > +bindings instead) > + > Required subnode-properties: > - brcm,pins: An array of cells. Each cell contains the ID of a pin. Valid IDs > are the integer GPIO IDs; 0==GPIO0, 1==GPIO1, ... 53==GPIO53. > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This series adds support for generic binding for pinctrl bcm2835 driver, and add the code for set output buffer of a pin using the output-low and output-high generic properties. Tested on Raspberry Pi Zero W, based on bcm2835 SoC. Changes since v3: (Suggested by Stefan Wahren) - Change dt-bindings docs patch order and subject Changes since v2: (Suggested by Eric Anholt) - Remove PACK and UNPACK macros - Use pinconf_to_config_* functions (Suggested by Stefan Wahren) - Fold Kconfig changes with the driver changes in a single patch - Add devicetree bindings documentations about generic properties support - Add devicetree bindings maintainers Matheus Castello (3): dt-bindings: pinctrl: bcm2835-gpio: Add generic pinctrl support pinctrl: bcm2835: Add support for generic pinctrl binding pinctrl: bcm2835: Add support for output-low output-high properties drivers/pinctrl/bcm/Kconfig | 1 + drivers/pinctrl/bcm/pinctrl-bcm2835.c | 92 ++++++++++++++-------- .../bindings/pinctrl/brcm,bcm2835-gpio.txt | 19 +++++ 3 files changed, 79 insertions(+), 33 deletions(-)
Matheus Castello <matheus@castello.eng.br> writes: > To keep driver up to date we add generic pinctrl binding support, which covers > the features used in this driver and has additional node properties that this > SoC has compatibility, so enabling future implementations of these properties > without the need to create new node properties in the device trees. > > The logic of this change maintain the old brcm legacy binding support in order > to keep the ABI stable. > > Signed-off-by: Matheus Castello <matheus@castello.eng.br> 2-3 are: Reviewed-by: Eric Anholt <eric@anholt.net>
diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt index 2569866..58b4720 100644 --- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt +++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt @@ -36,6 +36,25 @@ listed. In other words, a subnode that lists only a mux function implies no information about any pull configuration. Similarly, a subnode that lists only a pul parameter implies no information about the mux function. +This driver supports the generic pin multiplexing and configuration +bindings. For details on each properties, you can refer to +./pinctrl-bindings.txt. + +Required sub-node properties: + - pins + - function + +Optional sub-node properties: + - bias-disable + - bias-pull-up + - bias-pull-down + - output-high + - output-low + +Legacy pin configuration and multiplexing binding: +*** (Its use is deprecated, use generic multiplexing and configuration +bindings instead) + Required subnode-properties: - brcm,pins: An array of cells. Each cell contains the ID of a pin. Valid IDs are the integer GPIO IDs; 0==GPIO0, 1==GPIO1, ... 53==GPIO53.
Now we have generic pin configuration and multiplexing support, ahd shoud be preferred than brcm legacy one. Signed-off-by: Matheus Castello <matheus@castello.eng.br> --- .../devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)