[1/1] .gitignore: ignore outgoing directory

Message ID 20180308142907.3006-1-chrismcc@gmail.com
State Rejected
Headers show
Series
  • [1/1] .gitignore: ignore outgoing directory
Related show

Commit Message

Christopher McCrory March 8, 2018, 2:29 p.m.
The buildroot documentation for submitting patches creates a new
directory "outgoing".  This prevents git from nagging about untracked
files.

Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN April 22, 2018, 8:05 a.m. | #1
Christopher, All,

On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:
> The buildroot documentation for submitting patches creates a new
> directory "outgoing".  This prevents git from nagging about untracked
> files.
> 
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Peter, this is a candidate for 2018.02.x as well, I guess. ;-)

Regards,
Yann E. MORIN.

> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index bb02d9f572..f1a065d95e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,5 +1,6 @@
>  /output
>  /dl
> +/outgoing
>  /.auto.deps
>  /.config.cmd
>  /.config.old
> -- 
> 2.14.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni April 28, 2018, 4:44 p.m. | #2
Hello,

On Sun, 22 Apr 2018 10:05:32 +0200, Yann E. MORIN wrote:
> Christopher, All,
> 
> On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:
> > The buildroot documentation for submitting patches creates a new
> > directory "outgoing".  This prevents git from nagging about untracked
> > files.
> > 
> > Signed-off-by: Christopher McCrory <chrismcc@gmail.com>  
> 
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Peter, this is a candidate for 2018.02.x as well, I guess. ;-)

I'd like to challenge this patch: I am not super convinced. Creating a
outgoing/ directory is not "git format-patch" default behavior. By
default, the patches go in the current folder.

It's only the Buildroot manual that suggests to put them in an
outgoing/ folder (I'm not sure why). My feeling is that the Buildroot
manual just gives an example, and really users could put their patches
in any other folder, and we're not going to add all random folders
in .gitignore.

So I would say no to this patch, and therefore disagree with Yann's
Acked-by. Peter, Arnout, could you chime in and give your opinion about
this ?

Best regards,

Thomas
Yann E. MORIN April 28, 2018, 4:55 p.m. | #3
Thomas, All,

On 2018-04-28 18:44 +0200, Thomas Petazzoni spake thusly:
> On Sun, 22 Apr 2018 10:05:32 +0200, Yann E. MORIN wrote:
> > Christopher, All,
> > 
> > On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:
> > > The buildroot documentation for submitting patches creates a new
> > > directory "outgoing".  This prevents git from nagging about untracked
> > > files.
> > > 
> > > Signed-off-by: Christopher McCrory <chrismcc@gmail.com>  
> > 
> > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> > Peter, this is a candidate for 2018.02.x as well, I guess. ;-)
> 
> I'd like to challenge this patch: I am not super convinced. Creating a
> outgoing/ directory is not "git format-patch" default behavior. By
> default, the patches go in the current folder.
> 
> It's only the Buildroot manual that suggests to put them in an
> outgoing/ folder (I'm not sure why).

And I'm not even sure why we even creat the patches locally, when it is
perfectly possible to send them directly, e.g. to send the last three
patches:

    git send-email --to buidlroot@buildroot.org HEAD^^^..

Regards,
Yann E. MORIN.

> My feeling is that the Buildroot
> manual just gives an example, and really users could put their patches
> in any other folder, and we're not going to add all random folders
> in .gitignore.
> 
> So I would say no to this patch, and therefore disagree with Yann's
> Acked-by. Peter, Arnout, could you chime in and give your opinion about
> this ?
> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
Thomas Petazzoni April 28, 2018, 7:49 p.m. | #4
Hello,

On Sat, 28 Apr 2018 18:55:22 +0200, Yann E. MORIN wrote:

> > It's only the Buildroot manual that suggests to put them in an
> > outgoing/ folder (I'm not sure why).  
> 
> And I'm not even sure why we even creat the patches locally, when it is
> perfectly possible to send them directly, e.g. to send the last three
> patches:
> 
>     git send-email --to buidlroot@buildroot.org HEAD^^^..

I think for people beginning with git and patches, it is good to use
format-patch, so that you can check what the patches look like before
sending them.

Best regards,

Thomas
Carlos Santos May 12, 2018, 2:06 a.m. | #5
> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> To: "Yann Morin" <yann.morin.1998@free.fr>, "Christopher McCrory" <chrismcc@gmail.com>
> Cc: "buildroot" <buildroot@buildroot.org>
> Sent: Saturday, April 28, 2018 1:44:58 PM
> Subject: Re: [Buildroot] [PATCH 1/1] .gitignore: ignore outgoing directory

> Hello,
> 
> On Sun, 22 Apr 2018 10:05:32 +0200, Yann E. MORIN wrote:
>> Christopher, All,
>> 
>> On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:
>> > The buildroot documentation for submitting patches creates a new
>> > directory "outgoing".  This prevents git from nagging about untracked
>> > files.
>> > 
>> > Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
>> 
>> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> 
>> Peter, this is a candidate for 2018.02.x as well, I guess. ;-)
> 
> I'd like to challenge this patch: I am not super convinced. Creating a
> outgoing/ directory is not "git format-patch" default behavior. By
> default, the patches go in the current folder.
> 
> It's only the Buildroot manual that suggests to put them in an
> outgoing/ folder (I'm not sure why). My feeling is that the Buildroot
> manual just gives an example, and really users could put their patches
> in any other folder, and we're not going to add all random folders
> in .gitignore.
> 
> So I would say no to this patch, and therefore disagree with Yann's
> Acked-by. Peter, Arnout, could you chime in and give your opinion about
> this ?
> 
> Best regards,

If you want to ignore patches under outgoing/ then put something like
this in ~/.gitconfig:

[core]
        excludesFile = ~/.gitignore-global

And this in ~/.gitignore-global:

outgoing/*.patch
outgoing/*/*.patch

Patch

diff --git a/.gitignore b/.gitignore
index bb02d9f572..f1a065d95e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@ 
 /output
 /dl
+/outgoing
 /.auto.deps
 /.config.cmd
 /.config.old