[4/9] PCI: kirin_pcie_driver can be static

Message ID 20180307154243.3205-5-robh@kernel.org
State Superseded
Delegated to: Lorenzo Pieralisi
Headers show
Series
  • PCI DT header refactoring and compile test improvements
Related show

Commit Message

Rob Herring March 7, 2018, 3:42 p.m.
From: kbuild test robot <fengguang.wu@intel.com>

This was generated from 0-day builder.

Fixes: c44f2aed62c2 ("PCI: improve compile test coverage")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
[robh: add commit msg]
Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/pci/dwc/pcie-kirin.c    | 2 +-
 drivers/pci/host/pci-ftpci100.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Lorenzo Pieralisi March 8, 2018, 5:51 p.m. | #1
On Wed, Mar 07, 2018 at 09:42:38AM -0600, Rob Herring wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> 
> This was generated from 0-day builder.
> 
> Fixes: c44f2aed62c2 ("PCI: improve compile test coverage")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> [robh: add commit msg]
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/pci/dwc/pcie-kirin.c    | 2 +-
>  drivers/pci/host/pci-ftpci100.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
> index dcc8cedf6e17..a6b88c7f6e3e 100644
> --- a/drivers/pci/dwc/pcie-kirin.c
> +++ b/drivers/pci/dwc/pcie-kirin.c
> @@ -504,7 +504,7 @@ static const struct of_device_id kirin_pcie_match[] = {
>  	{},
>  };
>  
> -struct platform_driver kirin_pcie_driver = {
> +static struct platform_driver kirin_pcie_driver = {
>  	.probe			= kirin_pcie_probe,
>  	.driver			= {
>  		.name			= "kirin-pcie",
> diff --git a/drivers/pci/host/pci-ftpci100.c b/drivers/pci/host/pci-ftpci100.c
> index b9617d1c1d48..5008fd87956a 100644
> --- a/drivers/pci/host/pci-ftpci100.c
> +++ b/drivers/pci/host/pci-ftpci100.c
> @@ -586,11 +586,11 @@ static int faraday_pci_probe(struct platform_device *pdev)
>   * We encode bridge variants here, we have at least two so it doesn't
>   * hurt to have infrastructure to encompass future variants as well.
>   */
> -const struct faraday_pci_variant faraday_regular = {
> +static const struct faraday_pci_variant faraday_regular = {
>  	.cascaded_irq = true,
>  };
>  
> -const struct faraday_pci_variant faraday_dual = {
> +static const struct faraday_pci_variant faraday_dual = {
>  	.cascaded_irq = false,
>  };

It is more than kirin_pcie_driver then :), I can update the commit
log myself.

Lorenzo

Patch

diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
index dcc8cedf6e17..a6b88c7f6e3e 100644
--- a/drivers/pci/dwc/pcie-kirin.c
+++ b/drivers/pci/dwc/pcie-kirin.c
@@ -504,7 +504,7 @@  static const struct of_device_id kirin_pcie_match[] = {
 	{},
 };
 
-struct platform_driver kirin_pcie_driver = {
+static struct platform_driver kirin_pcie_driver = {
 	.probe			= kirin_pcie_probe,
 	.driver			= {
 		.name			= "kirin-pcie",
diff --git a/drivers/pci/host/pci-ftpci100.c b/drivers/pci/host/pci-ftpci100.c
index b9617d1c1d48..5008fd87956a 100644
--- a/drivers/pci/host/pci-ftpci100.c
+++ b/drivers/pci/host/pci-ftpci100.c
@@ -586,11 +586,11 @@  static int faraday_pci_probe(struct platform_device *pdev)
  * We encode bridge variants here, we have at least two so it doesn't
  * hurt to have infrastructure to encompass future variants as well.
  */
-const struct faraday_pci_variant faraday_regular = {
+static const struct faraday_pci_variant faraday_regular = {
 	.cascaded_irq = true,
 };
 
-const struct faraday_pci_variant faraday_dual = {
+static const struct faraday_pci_variant faraday_dual = {
 	.cascaded_irq = false,
 };