Patchwork [05/17] s390x: enable CPU_QuadU

login
register
mail settings
Submitter Alexander Graf
Date March 24, 2011, 3:58 p.m.
Message ID <1300982333-12802-6-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/88221/
State New
Headers show

Comments

Alexander Graf - March 24, 2011, 3:58 p.m.
From: Ulrich Hecht <uli@suse.de>

S390x uses the QuadU type, so let's enable it.

Signed-off-by: Ulrich Hecht <uli@suse.de>
---
 cpu-all.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Maydell - March 24, 2011, 4:52 p.m.
On 24 March 2011 15:58, Alexander Graf <agraf@suse.de> wrote:
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -138,7 +138,7 @@ typedef union {
>     uint64_t ll;
>  } CPU_DoubleU;
>
> -#ifdef TARGET_SPARC
> +#if defined(TARGET_SPARC) || defined(TARGET_S390X)
>  typedef union {
>     float128 q;
>  #if defined(HOST_WORDS_BIGENDIAN) \

I think this typedef should just be protected by
#ifdef CONFIG_SOFTFLOAT (because only softfloat defines
a float128 type) rather than by a set of TARGET_* checks.

If you do that then you can get rid of the "|| (defined(__arm__)
&& !defined(__VFP_FP__) && !defined(CONFIG_SOFTFLOAT))" part
of the inner ifdef, beacuse it's always false.

-- PMM
Alexander Graf - March 24, 2011, 4:54 p.m.
On 24.03.2011, at 17:52, Peter Maydell wrote:

> On 24 March 2011 15:58, Alexander Graf <agraf@suse.de> wrote:
>> --- a/cpu-all.h
>> +++ b/cpu-all.h
>> @@ -138,7 +138,7 @@ typedef union {
>>     uint64_t ll;
>>  } CPU_DoubleU;
>> 
>> -#ifdef TARGET_SPARC
>> +#if defined(TARGET_SPARC) || defined(TARGET_S390X)
>>  typedef union {
>>     float128 q;
>>  #if defined(HOST_WORDS_BIGENDIAN) \
> 
> I think this typedef should just be protected by
> #ifdef CONFIG_SOFTFLOAT (because only softfloat defines
> a float128 type) rather than by a set of TARGET_* checks.
> 
> If you do that then you can get rid of the "|| (defined(__arm__)
> && !defined(__VFP_FP__) && !defined(CONFIG_SOFTFLOAT))" part
> of the inner ifdef, beacuse it's always false.

I'm fairly indifferent on that one :).


Alex

Patch

diff --git a/cpu-all.h b/cpu-all.h
index 87b0f86..5a26d7a 100644
--- a/cpu-all.h
+++ b/cpu-all.h
@@ -138,7 +138,7 @@  typedef union {
     uint64_t ll;
 } CPU_DoubleU;
 
-#ifdef TARGET_SPARC
+#if defined(TARGET_SPARC) || defined(TARGET_S390X)
 typedef union {
     float128 q;
 #if defined(HOST_WORDS_BIGENDIAN) \