diff mbox series

enic: fix boolreturn.cocci warnings

Message ID 20180306182323.GA127477@lkp-g5
State Accepted, archived
Delegated to: David Miller
Headers show
Series enic: fix boolreturn.cocci warnings | expand

Commit Message

kbuild test robot March 6, 2018, 6:23 p.m. UTC 
From: Fengguang Wu <fengguang.wu@intel.com>

drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 48398b6e7065 ("enic: set UDP rss flag")
CC: Govindarajulu Varadarajan <gvaradar@cisco.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 vnic_dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller March 7, 2018, 6:37 p.m. UTC | #1 
From: kbuild test robot <fengguang.wu@intel.com>
Date: Wed, 7 Mar 2018 02:23:23 +0800

> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: 48398b6e7065 ("enic: set UDP rss flag")
> CC: Govindarajulu Varadarajan <gvaradar@cisco.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied to net-next.
diff mbox series

Patch

--- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
@@ -1291,7 +1291,7 @@  bool vnic_dev_capable_udp_rss(struct vni
 
 	err = vnic_dev_cmd(vdev, CMD_CAPABILITY, &a0, &a1, wait);
 	if (err || !a0)
-		return 0;
+		return false;
 
 	rss_hash_type = (a1 >> NIC_CFG_RSS_HASH_TYPE_SHIFT) &
 			NIC_CFG_RSS_HASH_TYPE_MASK_FIELD;