Patch for opencv3: python module was built for the host instead of target.

Message ID MW2PR02MB3724CAF4A9F9EF9FEBF4C35E95D90@MW2PR02MB3724.namprd02.prod.outlook.com
State Accepted
Headers show
Series
  • Patch for opencv3: python module was built for the host instead of target.
Related show

Commit Message

Shyrokov, Sasha March 6, 2018, 5:19 p.m.
From 9b211fb5ec49879d10d32d22ed3608ffca944e2d Mon Sep 17 00:00:00 2001
From: Sasha Shyrokov <alexander-shyrokov@idexx.com>
Date: Tue, 6 Mar 2018 10:58:10 -0500
Subject: [PATCH 1/1] opencv3: python module was built for the host instead of target.

distutils environment variables must be set.
OPENCV3_CONF_ENV = $(PKG_PYTHON_DISTUTILS_ENV) All credit goes to Arnout:
https://stackoverflow.com/questions/49059035/buildroot-opencv3-python-package-builds-for-the-wrong-target

Signed-off-by: Sasha Shyrokov <alexander-shyrokov@idexx.com>
---
 package/opencv3/opencv3.mk | 1 +
 1 file changed, 1 insertion(+)

buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Comments

Thomas Petazzoni April 1, 2018, 8:50 a.m. | #1
Hello,

On Tue, 6 Mar 2018 17:19:18 +0000, Shyrokov, Sasha wrote:
> From 9b211fb5ec49879d10d32d22ed3608ffca944e2d Mon Sep 17 00:00:00 2001
> From: Sasha Shyrokov <alexander-shyrokov@idexx.com>
> Date: Tue, 6 Mar 2018 10:58:10 -0500
> Subject: [PATCH 1/1] opencv3: python module was built for the host instead of target.
> 
> distutils environment variables must be set.
> OPENCV3_CONF_ENV = $(PKG_PYTHON_DISTUTILS_ENV) All credit goes to Arnout:
> https://stackoverflow.com/questions/49059035/buildroot-opencv3-python-package-builds-for-the-wrong-target
> 
> Signed-off-by: Sasha Shyrokov <alexander-shyrokov@idexx.com>
> ---
>  package/opencv3/opencv3.mk | 1 +
>  1 file changed, 1 insertion(+)

Thanks, I've applied after extending the commit log to explain the
problem in more details, and apply the solution also to Python 2.x fo
consistency, even if it's only strictly needed for Python 3.x.

See
https://git.buildroot.org/buildroot/commit/?id=8ba80282c3bb580c6a45ea114e70acac98fe1690

Thanks for your contribution!

Thomas
Peter Korsgaard April 8, 2018, 3:07 p.m. | #2
>>>>> "Shyrokov," == Shyrokov, Sasha <Sasha-Shyrokov@idexx.com> writes:

 > From 9b211fb5ec49879d10d32d22ed3608ffca944e2d Mon Sep 17 00:00:00 2001
 > From: Sasha Shyrokov <alexander-shyrokov@idexx.com>
 > Date: Tue, 6 Mar 2018 10:58:10 -0500
 > Subject: [PATCH 1/1] opencv3: python module was built for the host instead of target.

 > distutils environment variables must be set.
 > OPENCV3_CONF_ENV = $(PKG_PYTHON_DISTUTILS_ENV) All credit goes to Arnout:
 > https://stackoverflow.com/questions/49059035/buildroot-opencv3-python-package-builds-for-the-wrong-target

 > Signed-off-by: Sasha Shyrokov <alexander-shyrokov@idexx.com>

Committed to 2018.02.x, thanks.

Patch

diff --git a/package/opencv3/opencv3.mk b/package/opencv3/opencv3.mk index cffe66b892..46d216db90 100644
--- a/package/opencv3/opencv3.mk
+++ b/package/opencv3/opencv3.mk
@@ -328,6 +328,7 @@  OPENCV3_CONF_OPTS += \  OPENCV3_DEPENDENCIES += python3  endif  OPENCV3_DEPENDENCIES += python-numpy
+OPENCV3_CONF_ENV = $(PKG_PYTHON_DISTUTILS_ENV)
 else
 OPENCV3_CONF_OPTS += \
        -DBUILD_opencv_python2=OFF \
--
2.14.1

_______________________________________________