From patchwork Thu Mar 24 15:14:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 88213 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id CE9921007D1 for ; Fri, 25 Mar 2011 02:14:22 +1100 (EST) Received: (qmail 25886 invoked by alias); 24 Mar 2011 15:14:21 -0000 Received: (qmail 25877 invoked by uid 22791); 24 Mar 2011 15:14:20 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Mar 2011 15:14:15 +0000 Received: by wyb40 with SMTP id 40so34244wyb.20 for ; Thu, 24 Mar 2011 08:14:14 -0700 (PDT) Received: by 10.227.171.207 with SMTP id i15mr7725512wbz.121.1300979654005; Thu, 24 Mar 2011 08:14:14 -0700 (PDT) Received: from richards-thinkpad (gbibp9ph1--blueice2n1.emea.ibm.com [195.212.29.75]) by mx.google.com with ESMTPS id ed10sm2332wbb.49.2011.03.24.08.14.11 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Mar 2011 08:14:12 -0700 (PDT) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Subject: Re: Cleaning up expand optabs code References: <4D825EF5.1010307@redhat.com> <87wrju28hn.fsf@firetop.home> <4D87A69B.90704@redhat.com> Date: Thu, 24 Mar 2011 15:14:10 +0000 In-Reply-To: (Richard Sandiford's message of "Tue, 22 Mar 2011 15:08:54 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This showed up as a warning during the h8300 build I did this morning. I've no idea why it wasn't caught during the x86_64, ARM and MIPS testing. Bootstrapped & regression-tested on x86_64-linux-gnu. Installed as obvious. Richard gcc/ * builtins.c (expand_movstr): Fix endp == 1 adjustment after last commit. Index: gcc/builtins.c =================================================================== --- gcc/builtins.c 2011-03-23 09:30:17.000000000 +0000 +++ gcc/builtins.c 2011-03-24 09:08:05.000000000 +0000 @@ -3655,7 +3655,6 @@ expand_builtin_mempcpy_args (tree dest, expand_movstr (tree dest, tree src, rtx target, int endp) { struct expand_operand ops[3]; - rtx end; rtx dest_mem; rtx src_mem; @@ -3683,7 +3682,7 @@ expand_movstr (tree dest, tree src, rtx adjust it. */ if (endp == 1) { - rtx tem = plus_constant (gen_lowpart (GET_MODE (target), end), 1); + rtx tem = plus_constant (gen_lowpart (GET_MODE (target), target), 1); emit_move_insn (target, force_operand (tem, NULL_RTX)); } }