| Message ID | 20180306075448.1179-1-haoqf@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] iotests: bypass s390x for case 200 | expand |
Nack. This will be fixed by s390/ipl: only print boot menu error if -boot menu=on was specified On 03/06/2018 08:54 AM, QingFeng Hao wrote: > In s390x, the case 200 failed as: > === Starting QEMU VM === > > +QEMU_PROG: boot menu is not supported for this device type. > {"return": {}} > > === Sending stream/cancel, checking for SIGSEGV only === > Failures: 200 > Failed 1 of 1 tests > > It was caused by the command which isn't supported by s390x now: > qemu-system-s390x -device pci-bridge,id=bridge1,chassis_nr=1,bus=pci.0 -object iothread,id=iothread0 -device virtio-scsi-pci,bus=bridge1,addr=0x1f,id=scsi0,iothread=iothread0 -drive file=.../scratch/test.img,media=disk,if=none,cache=writeback,id=drive_sysdisk,format=qcow2 -device scsi-hd,drive=drive_sysdisk,bus=scsi0.0,id=sysdisk,bootindex=0 -nographic > > Signed-off-by: QingFeng Hao <haoqf@linux.vnet.ibm.com> > --- > tests/qemu-iotests/200 | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/qemu-iotests/200 b/tests/qemu-iotests/200 > index ddbdedc476..7e53bd7774 100755 > --- a/tests/qemu-iotests/200 > +++ b/tests/qemu-iotests/200 > @@ -45,6 +45,10 @@ _supported_fmt qcow2 qed > _supported_proto file > _supported_os Linux > > +if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then > + _notrun "Requires a PC machine" > +fi > + > BACKING_IMG="${TEST_DIR}/backing.img" > TEST_IMG="${TEST_DIR}/test.img" >
在 2018/3/6 15:56, Christian Borntraeger 写道: > Nack. This will be fixed by > > s390/ipl: only print boot menu error if -boot menu=on was specified You are right. After I applied that patch, the case is passed. Please ignore this patch. Thanks > > On 03/06/2018 08:54 AM, QingFeng Hao wrote: >> In s390x, the case 200 failed as: >> === Starting QEMU VM === >> >> +QEMU_PROG: boot menu is not supported for this device type. >> {"return": {}} >> >> === Sending stream/cancel, checking for SIGSEGV only === >> Failures: 200 >> Failed 1 of 1 tests >> >> It was caused by the command which isn't supported by s390x now: >> qemu-system-s390x -device pci-bridge,id=bridge1,chassis_nr=1,bus=pci.0 -object iothread,id=iothread0 -device virtio-scsi-pci,bus=bridge1,addr=0x1f,id=scsi0,iothread=iothread0 -drive file=.../scratch/test.img,media=disk,if=none,cache=writeback,id=drive_sysdisk,format=qcow2 -device scsi-hd,drive=drive_sysdisk,bus=scsi0.0,id=sysdisk,bootindex=0 -nographic >> >> Signed-off-by: QingFeng Hao <haoqf@linux.vnet.ibm.com> >> --- >> tests/qemu-iotests/200 | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/tests/qemu-iotests/200 b/tests/qemu-iotests/200 >> index ddbdedc476..7e53bd7774 100755 >> --- a/tests/qemu-iotests/200 >> +++ b/tests/qemu-iotests/200 >> @@ -45,6 +45,10 @@ _supported_fmt qcow2 qed >> _supported_proto file >> _supported_os Linux >> >> +if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then >> + _notrun "Requires a PC machine" >> +fi >> + >> BACKING_IMG="${TEST_DIR}/backing.img" >> TEST_IMG="${TEST_DIR}/test.img" >>
diff --git a/tests/qemu-iotests/200 b/tests/qemu-iotests/200 index ddbdedc476..7e53bd7774 100755 --- a/tests/qemu-iotests/200 +++ b/tests/qemu-iotests/200 @@ -45,6 +45,10 @@ _supported_fmt qcow2 qed _supported_proto file _supported_os Linux +if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then + _notrun "Requires a PC machine" +fi + BACKING_IMG="${TEST_DIR}/backing.img" TEST_IMG="${TEST_DIR}/test.img"
In s390x, the case 200 failed as: === Starting QEMU VM === +QEMU_PROG: boot menu is not supported for this device type. {"return": {}} === Sending stream/cancel, checking for SIGSEGV only === Failures: 200 Failed 1 of 1 tests It was caused by the command which isn't supported by s390x now: qemu-system-s390x -device pci-bridge,id=bridge1,chassis_nr=1,bus=pci.0 -object iothread,id=iothread0 -device virtio-scsi-pci,bus=bridge1,addr=0x1f,id=scsi0,iothread=iothread0 -drive file=.../scratch/test.img,media=disk,if=none,cache=writeback,id=drive_sysdisk,format=qcow2 -device scsi-hd,drive=drive_sysdisk,bus=scsi0.0,id=sysdisk,bootindex=0 -nographic Signed-off-by: QingFeng Hao <haoqf@linux.vnet.ibm.com> --- tests/qemu-iotests/200 | 4 ++++ 1 file changed, 4 insertions(+)