| Message ID | 1520259883-4929-4-git-send-email-patrick.delaunay@st.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | arm: stm32mp1: add initial support for STM32MP157 | expand |
Hi Patrick, On 5 March 2018 at 07:24, Patrick Delaunay <patrick.delaunay@st.com> wrote: > > avoid warning: no previous prototype for ‘mach_cpu_init’ > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > include/common.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/common.h b/include/common.h > index 0fe9439..5b6f788 100644 > --- a/include/common.h > +++ b/include/common.h > @@ -474,6 +474,16 @@ int is_core_valid (unsigned int); > */ > int arch_cpu_init(void); > > +/** > + * mach_cpu_init() - SoC/machine dependent CPU setup > + * > + * This is called after arch_cpu_init(). It should handle any > + * SoC or machine specific init needed to continue the init sequence. See > + * board_f.c for where it is called. If this is not provided, a default > + * version (which does nothing) will be used. Great, but can you please add @return docs? > + */ > +int mach_cpu_init(void); > + > void s_init(void); > > int checkcpu (void); > -- > 2.7.4 > Regards, Simon
Hi Simon > -----Original Message----- > From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass > > Hi Patrick, > > On 5 March 2018 at 07:24, Patrick Delaunay <patrick.delaunay@st.com> wrote: > > > > avoid warning: no previous prototype for ‘mach_cpu_init’ > > +/** > > + * mach_cpu_init() - SoC/machine dependent CPU setup > > + * > > + * This is called after arch_cpu_init(). It should handle any > > + * SoC or machine specific init needed to continue the init sequence. > > +See > > + * board_f.c for where it is called. If this is not provided, a > > +default > > + * version (which does nothing) will be used. > > Great, but can you please add @return docs? Yes, I will do it @return: 0 on success, otherwise error I will also add the same for arch_cpu_init() in the same patch... but after check, the warning is no more present in the v1 Serie after rework before push, because mach_stm32mp don't use mach_cpu_init() but arch_cpu_init(). So this patch is not more required for my stm32mp arch (and I will remove it in V2 serie) But I will sent today just this patch in v2 (without Serie). > > Regards, > Simon Regards Patrick
diff --git a/include/common.h b/include/common.h index 0fe9439..5b6f788 100644 --- a/include/common.h +++ b/include/common.h @@ -474,6 +474,16 @@ int is_core_valid (unsigned int); */ int arch_cpu_init(void); +/** + * mach_cpu_init() - SoC/machine dependent CPU setup + * + * This is called after arch_cpu_init(). It should handle any + * SoC or machine specific init needed to continue the init sequence. See + * board_f.c for where it is called. If this is not provided, a default + * version (which does nothing) will be used. + */ +int mach_cpu_init(void); + void s_init(void); int checkcpu (void);
avoid warning: no previous prototype for ‘mach_cpu_init’ Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- include/common.h | 10 ++++++++++ 1 file changed, 10 insertions(+)