From patchwork Mon Mar 5 11:06:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 881404 X-Patchwork-Delegate: cyrille.pitchen@atmel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sfKf/qtc"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Ty6eJS4Z"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zvxxt35q2z9sZb for ; Mon, 5 Mar 2018 22:09:38 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=odoDrEU+78btWWgOwOahuEyinOsFHTR/O6PlQ9Ylo/o=; b=sfKf/qtcCpEOKb j/HOF8ZJz2IaXTtJjvpil6s8F3WNzEFkeWXaAhgKxitmwLrvarKkq3Ck87OSsjMwHzeu6mOtOyxIv TYVduaXzGez7io9Dj2RXY+rXrOJRjj2PS8hMQZfsMn+Fwa+uXBUTRteyy/zR3obLfGyTtrouXHHLQ rDXfjQ5ieThqf2atV5FasKT6dg/K8zlkmozJgxP92J6wm1JdDdiIYtXHzPjHhLTc1Rnia1H9CgaYm pbX4wUZVb8CEVSAR8qBKgXlzJ1tju8NiUKZdKVhjboLbipwYO7Q5jQVivxN3F22x+GAs3Nu+hSRP2 yXpOVf+gh2kfgNjl/bnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1esnzm-00013q-Sz; Mon, 05 Mar 2018 11:09:30 +0000 Received: from mail-eopbgr30061.outbound.protection.outlook.com ([40.107.3.61] helo=EUR03-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1esnyt-0000N7-0N for linux-mtd@lists.infradead.org; Mon, 05 Mar 2018 11:08:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E/df4W1TeaG3y82mh1F4BIxUfuwu1TPKHZt/n0h7vME=; b=Ty6eJS4ZBCh7QF40BDqOnHGtrkbDKmb1YVxD3MgMm0jxg/qZAHvQESDRMBuyQAKMTcSNOVUNlVZuldAuue0DCUdkpE5f6vYk213euXPy87svCIy2Z7QisMJqCBSU0ur/qeYW4RBHb1veG4LRArHY1O25RaJZi5LeTNBTTZqPP5o= Received: from idcbfarm.ap.freescale.net (14.142.187.166) by DB6PR0402MB2838.eurprd04.prod.outlook.com (2603:10a6:4:98::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 5 Mar 2018 11:08:22 +0000 From: Yogesh Gaur To: linux-mtd@lists.infradead.org Subject: [PATCH v6 2/2] mtd: fsl-quadspi: fix init AHB read in fsl_qspi_nor_setup() Date: Mon, 5 Mar 2018 16:36:59 +0530 Message-Id: <1520248019-2828-3-git-send-email-yogeshnarayan.gaur@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1520248019-2828-1-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1520248019-2828-1-git-send-email-yogeshnarayan.gaur@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: HK2PR02CA0159.apcprd02.prod.outlook.com (2603:1096:201:1f::19) To DB6PR0402MB2838.eurprd04.prod.outlook.com (2603:10a6:4:98::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e6b686cc-0eb5-4667-2643-08d582896b83 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:DB6PR0402MB2838; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2838; 3:Mu+Hv8CM1KAWyjeWTURBZ6Gqnh9KX1Af3SaFrVAX8Rak2AW/7EtKrMH40luxDcNUDLbCz72YMmafQdBJ4AEMHnWxt0s/fbhS15go3W61dzRMpKn7dEeXFMGruyMpjx0JZCZAGVkz/emJggyywafQ8CgcTBEFsuGvaJMiNACSzINTFj51VHsbw/x7/LU1Xxj8CjCFX5LQUJGR3JnYLPJuaP2whGKudgP9SmjdoDTH546IRDFUoNx1/f/OfpT52b7A; 25:+6asjHyw1yYYbHB4WQp4UPtHlcWNh4eWnkjxdIEYfsmLBBbYdRqMaYpW39P14k/UybnhCyh4Wm7NTLyqoBVn0ZF+rwKSrHPIEjraghdw2D1E7s/9slzEDqEEr7tdNFSsJJcOBihjXJk7NhKD3s2BhMiB2oec8gkpjLKk0E3HKkU2dYpjv5Xc4yLollgH3DBOD0FZC5/QJDmM6o+rMWrcam6WGK6daqkL7tQrtMxY5SFMUqE+P4heoqmuWX2tGMfC4aae1lpfDRr05L8CanQPDVXjVgxGX1jB2nRbNMJUf9s/I7xKV2G5pPa2rnD523kZvcGtbmHHUBTyu/LDNfDYdg==; 31:gwWlcHY5VfIjv9Y98kxf7Of+3aRro5xmquBtiVVZBAde4BIfKD2hBEc2iaZLggoief5jm/d1b5Sgzh22NGojwa+aLIEirt8JYrDLwIdGp1QFC8xI481DxUFadkFnYkuj9ag98TCWETPqCQxOhWEebJ8pdCKmRHQ42wYpCIpeSuiPWKqkb3g2EB0RgZAx7+L87H6VwFvb+K0d7fNk1OQN0EtbTU+pQPjDymR0klus2nY= X-MS-TrafficTypeDiagnostic: DB6PR0402MB2838: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2838; 20:FKlAXzuA28vZMAd/8vfPQrvMlZGeoPmKP+/B/e9BdBmVr8matwCc9KlO5qXrPN75TPFNqvSI13HtiSmZSiKSvdXcASmDbdxdqdEj+awQyfB1N5F8X7EgrCw+3OIPdd8b44lmktGq01RekpTnNqqUuyAV55DnT6MYgJRPkK+lyf+rVNGIg2UDkValaEuTau/oabtJIeGyuKPd/Wm+304zAYeEunYHZ8BeTw5neeALySULdv/pk8J+AKdyJDrGKbSIUbyS5hvMEbDinRUbFBjGHdnmd1rX5Et8vimuOsdpKkxRdmteOOWWrOCoql0n1DInkdVp9X6UgZ32zgT6fd3QNGL6r93PjXGNEH6kIIAx58oJld2cfiYWfBE4ZPaRyR2xUGWMcO4lZncoUm+2dy3ZOr970tmO/Cydaa9uT1DUEm/Rxnq5V0xJnp9IP4qOJp48r+KPz66daa2cTMgjlEoYjGg8yimRx1iTP6lMQvG8IloOi7TxSKYb5rjLRFKTaaE6; 4:N8UhXFjJstjgEiE0NAMnU6hWDHCimYIdQz/pt7Rt5kpuKIXCObqAsnxQFwZD/zyid/MtBeBlNMXUU4kgRXyqYtsAxdMPABkCJXB0Qhpiz6DT7Tst/NfTl88hmSD1ijs2HtY/lnp46RwnlI0YBUC2xihMlA+qjJCQm4BQbJSMfg7Qdhm1Tuu+ylK696rzguTaasLIwiTsj0lbXeTwojMew1GfUrOd6qca5Ny1BSDIT7zekvCSG/epIt1q0jHBE9q3FViLCWPxxndSVCakoWTKxApZEEl4Em/kpountsprWJhwCumBSw/+o/7hLEGOcgC7BFzjscwOwneoM3l7h0ZbDMLPdJvOVR9ZeNN9ALQAx30= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(3002001)(6055026)(6041288)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DB6PR0402MB2838; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0402MB2838; X-Forefront-PRVS: 06022AA85F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(396003)(376002)(346002)(39860400002)(199004)(189003)(51416003)(305945005)(4326008)(16526019)(386003)(6506007)(16586007)(106356001)(478600001)(316002)(53936002)(50226002)(55236004)(68736007)(6916009)(2950100002)(6666003)(81156014)(50466002)(8936002)(26005)(6512007)(81166006)(2361001)(47776003)(105586002)(3846002)(2351001)(6116002)(186003)(66066001)(8676002)(52116002)(7736002)(48376002)(6486002)(39060400002)(5660300001)(76176011)(2906002)(5009440100003)(36756003)(86362001)(97736004)(25786009)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0402MB2838; H:idcbfarm.ap.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0402MB2838; 23:qVTTeUf8RjR7uYTg1jWl3MSj/vMWAhZCSk7X2hZ?= 4CyFaUNB+5ZjbfnR4tnvDHBG/5xzaMtD+2doa1VYPaHqsGGCh8NV3hjbuZ4z9fiGvwm6cMrecziPL5DVYLrHcCsr6Tr7lsN6Yr6e1zgcsBLX7Km0D952/ekDdzqBgaXxUVT9cO2Sf+f7/F8Y9O8kWwe3i4S5PX8x5vnB8Gud0WvfoWkPYcw0H6FmjunyBLl3tzMJ4vJqCmTbCVH014ENiOwT9KbugUGgFU3H9tOdAjgC2cRcVZ1JP1DSjXa0K8keZYjFyD4CNIZ0A9ReuD9fWKT4pccxnxFTe5ZGz4J2sXvFp2Rl3mvLRvTNePhMf6C4dv50YF1+tjTtsI0k8bVCXy2HI/MvW9OsoiO3bd2C6SoUZekP34PfJfmh9YFYyhUe4C/vSYW86cOoMMSpKROIla2nrGQfhhXcXxc6+7TYaRDj79u0QpO7Y3XC3pr/0ge/roErGD8rrxUtLddM2OBPn5cI/GBlh87mG++U3Xy2N+nICHAq901T/N3KJE05xhn9K7Od087ZjOSRe0qjofE/6KOJKsM+1pWDA92lo30A7mYEQNtIvkP40YJSrmAdDdVR6tqIqpQvCo5JmXwL21LfRFi4egAdxMvz8PFL09YqljZxB358CQyMLgaVRt5v3Tq4zAa60+GUuMk4ZWn3+7qWC1dE40kAxkSAf0uW8cePKQRnlGqRmr+xIiuV59ge/46rWnyNfyCPNNwL2FKOQemi0B7WjGOg+/e2Nb/BTsvc995IV5VPKYKgiP9vYM+cnF6DPCZLql2fBG1joFweNcZquVN9FzbTcoPBQgCI8hEAr2XWp4yVmW4B6o4fwn35QCKULPqQJNq+e65DZn0ALbkNEIZzfek0azS3u9ztANFl6Pyrx0VpU36C9sAW28l1sxorsAkKN+UUOnobd/McSw8fAVT7wPh7rsdeRfcFOcHq7EmuymyhkiBbgrIXdnT15WOZ/WP8HL4fzmk3IBdshB0hMipfnLsOHxqy9eTkzPn/xF9qMX8Kkjy6Ex/Ei/kxT9h+t3hfBvVvUM8kdz4k6q6UvICaa6ZmPiXGV94mkc6rrAoF43l3MYmwCs+DA/irO+GxgZmr9sNKAkIPV30y7JjBYUAWtKcBFdsAsPDSIUfaLot5qBbyjIAIYc4P1ZAsRYBnXMJdCbIQjV4Fqh2f8dGKciKpRm6+WUg+QXseWCdJDMd19raO2tLDfLqLoSwR29QFsaDc= X-Microsoft-Antispam-Message-Info: MdEYi2PVpYF04wi0PzWFmbA0r/8XxKvy/cFEnsIS6mgv2z1tCkVn/RbzNR05JWgrzHhP/9c7QIN0y1Ud/Yh174WXHZC1gSdxSfe2A4GeVLyyOKFn3QL6yLZRH+62WRleoHa+bEmqUDa6iEnvkHdD44OOlB1XGIjTr+Etz6tCzkG41XkHXdzGDn8usL3HvuaY X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2838; 6:hHKLASzFuKWItL9DIp4YNwQ6uUkHdu51bLgZyRBYS2C7+DsU0DrBXR8DECsPhxlQpEJslXQ21puGHJHTtad+29T9aTvED/DacSe+opZS9ELyPeeligPB5XdV03umY5zOZaCfnXXiWyF/ZwX7ymcI6T/jlvcP7vLxbkt2Gef5+q6XTgzB0gHQc2rSs041z2UOJDnGpJQWiIWVg7ImGKg6QXy9RtJ2Cr2YoQzczxgl3QagMlbspIruas+pOiQ2/shov4xPAhiw7JuycQLDwdGwAZ4SJdd1b1Fvafa0y1ykIARGlsRI4S+P+3slgMMDkKzK+O1wdsVU3XZkvYb7+zkDNXt2ZQ6WWrLojUa81Qy/g/8=; 5:LEH37R8jP1KKXlen4EYpRaz72RPONWYkEWQCl3/LAxXaCuHhMD/6gC9cL8e1D8u3LtBl6u2CLmcJM1o25jAdw7qd5y6d+7+XDaXk25oC+vs84u5KNgkxhftQ16t2e5dZw2OJBfHBYZo3CAOSod2I8CWErAjL/FNsMGMRp3MXix8=; 24:VbDwr0oFEh/KITF1kbnfxgiGGizITv4ldWuURR2qN/EvBvx+iKjGsgJ1KUD/foSknwle0CHFMv+svsDu1TaTcmV23HJRTe+bcBCWApf8OzY=; 7:0IVJibY+RD9S8IE6D8g8FSWKmi6mc5T/tJucjBy6xssAsdjKAgmXTNgWVgl4/aW4CYsuOsmv5jj43DysKXULSGBRrZuKnuA0AV+Qmy1vtIQM4Wv9nC4oEHht4Wyc5NBN7OsBjf9YCy6Vd1RLkkEhws/W2i4JCYynWMmT21hdcIYEnVcEb1AcsNJoKfjS2fB1agrFsJitjHOtTXwRcVlkJljLf6YlyDaxEXPm8rqhHKCAlS6jeIvgLDCsWyWwnom+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2018 11:08:22.3837 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6b686cc-0eb5-4667-2643-08d582896b83 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2838 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180305_030835_438708_6B56AE91 X-CRM114-Status: GOOD ( 10.02 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [40.107.3.61 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.3.61 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: boris.brezillon@free-electrons.com, Yogesh Gaur , marek.vasut@gmail.com, frieder.schrempf@exceet.de, prabhakar.kushwaha@nxp.com, suresh.gupta@nxp.com, cyrille.pitchen@wedev4u.fr, han.xu@nxp.com, computersforpeace@gmail.com, festevam@gmail.com Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Move AHB read initialize in fsl_qspi_nor_setup(). In file spi-nor.c, func spi_nor_scan() calls nor->read() thru spi_nor_read_sfdp() API. Presently, fsl_qspi_init_ahb_read() called from fsl_qspi_nor_setup_last(). Func fsl_qspi_probe() calls spi_nor_scan() first and then calls fsl_qspi_nor_setup_last(). When nor->read() being called from inside spi_nor_read_sfdp(), QSPI cntlr AHB mode initialization is not yet done results in data read error. Initialize AHB read inside fsl_qspi_nor_setup(). Signed-off-by: Yogesh Gaur --- Changes for v6: - None Changes for v5: - None Changes for v4: - None Changes for v3: - None Changes for v2: - None drivers/mtd/spi-nor/fsl-quadspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index d2e8421..8f05be2 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -819,6 +819,9 @@ static int fsl_qspi_nor_setup(struct fsl_qspi *q) /* enable the interrupt */ qspi_writel(q, QUADSPI_RSER_TFIE, q->iobase + QUADSPI_RSER); + /* Init for AHB read */ + fsl_qspi_init_ahb_read(q); + return 0; } @@ -841,9 +844,6 @@ static int fsl_qspi_nor_setup_last(struct fsl_qspi *q) if (ret) return ret; - /* Init for AHB read */ - fsl_qspi_init_ahb_read(q); - /* Prepare LUT for AHB read - required for read from devmem interface */ fsl_qspi_prep_ahb_read(q);